From: Simon Horman <horms@verge.net.au>
To: David Miller <davem@davemloft.net>
Cc: macro@linux-mips.org, joe@perches.com,
hartleys@visionengravers.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] lib/vsprintf.c: Add %pMF to format FDDI bit reversed MAC addresses
Date: Fri, 8 Jan 2010 11:08:48 +1100 [thread overview]
Message-ID: <20100108000843.GI2436@verge.net.au> (raw)
In-Reply-To: <20100107.140942.135976087.davem@davemloft.net>
On Thu, Jan 07, 2010 at 02:09:42PM -0800, David Miller wrote:
> From: "Maciej W. Rozycki" <macro@linux-mips.org>
> Date: Thu, 7 Jan 2010 20:42:12 +0000 (GMT)
>
> > What's the gain? I'd be rather conservative when taking everybody's 56
> > bytes for one or two drivers hardly anybody uses. The format of MAC
> > addresses is unlikely to change, so I'd say the sources can live with
> > one or two places where the strings are formatted manually. Even if the
> > drivers lose more than these 56 bytes.
>
> We gain consistency. You know, the part that's completely bolixed
> right now?
>
> I'm applying Joe's patch and followon patches to make the driver's
> use the new printf format.
In the vein of this, would it be worth adding some modifier to %i4 to
print addresses for ftp helpers? That is, %u,%u,%u,%u. I think
there are currently two users of that format string after Joe's latest
round of updates.
The users are net/netfilter/ipvs/ip_vs_ftp.c and
net/ipv4/netfilter/nf_nat_ftp.c. Prior to Joe's latest
changes ip_vs_ftp.c used %d,%d,%d,%d.
next prev parent reply other threads:[~2010-01-08 0:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BD79186B4FD85F4B8E60E381CAEE19090208954A@mi8nycmail19.Mi8.com>
2010-01-07 18:23 ` [PATCH] lib/vsprintf.c: Add %pMF to format FDDI bit reversed MAC addresses Joe Perches
2010-01-07 20:42 ` Maciej W. Rozycki
2010-01-07 21:13 ` Michał Mirosław
2010-01-07 22:09 ` David Miller
2010-01-08 0:08 ` Simon Horman [this message]
2010-01-08 1:51 ` Joe Perches
2010-01-08 2:48 ` Simon Horman
2010-01-07 21:18 ` Michał Mirosław
2010-01-07 21:36 ` Joe Perches
2010-01-07 21:37 ` [PATCH V2] " Joe Perches
2010-01-07 22:11 ` David Miller
2010-01-07 21:43 ` [PATCH V3] " Joe Perches
2010-01-08 0:58 ` David Miller
2010-01-19 10:57 ` [PATCH] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100108000843.GI2436@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).