[PATCH/next] mac8390: Fix build breakage

[PATCH/next] mac8390: Fix build breakage

[Geert Uytterhoeven]

commit 18c0019102228875cb0f6f252dad5148491e96b2 ("drivers/net/mac8390.c:
Convert printk(KERN_<level> to pr_<level>(") broke the build:

| drivers/net/mac8390.c:306: error: expected ')' before 'version'

as "version" is not a string literal, but a variable.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
http://kisskb.ellerman.id.au/kisskb/buildresult/1985016/

 drivers/net/mac8390.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/mac8390.c b/drivers/net/mac8390.c
index c70bd68..a876867 100644
--- a/drivers/net/mac8390.c
+++ b/drivers/net/mac8390.c
@@ -303,7 +303,7 @@ static bool __init mac8390_init(struct net_device *dev, struct nubus_dev *ndev,
 	int offset;
 	volatile unsigned short *i;
 
-	printk_once(KERN_INFO pr_fmt(version));
+	printk_once(KERN_INFO pr_fmt("%s"), version);
 
 	dev->irq = SLOT2IRQ(ndev->board->slot);
 	/* This is getting to be a habit */
-- 
1.6.0.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH/next] mac8390: Fix build breakage

[David Miller]

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sat, 9 Jan 2010 14:21:28 +0100 (CET)

> commit 18c0019102228875cb0f6f252dad5148491e96b2 ("drivers/net/mac8390.c:
> Convert printk(KERN_<level> to pr_<level>(") broke the build:
> 
> | drivers/net/mac8390.c:306: error: expected ')' before 'version'
> 
> as "version" is not a string literal, but a variable.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thanks.