netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, ilpo.jarvinen@helsinki.fi
Subject: Re: BSD 4.2 style TCP keepalives
Date: Fri, 8 Jan 2010 20:22:27 -0500	[thread overview]
Message-ID: <20100109012227.GA2762@localhost.localdomain> (raw)
In-Reply-To: <20100108.132107.38069748.davem@davemloft.net>

On Fri, Jan 08, 2010 at 01:21:07PM -0800, David Miller wrote:
> From: Neil Horman <nhorman@tuxdriver.com>
> Date: Fri, 8 Jan 2010 07:40:33 -0500
> 
> > Dave, sorry about this, but it looks like we can scrap this, I just
> > looked at the initial tcpdump this was reported in, and apparently
> > w2k doesn't compute the checksum properly on these old style
> > keepalives.
> 
> Thanks for the update.  Nothing to be sorry about, this is actually a
> relief and we learned a lot about keepalives and zero-window probes in
> the process :-)
> 

I'm trying to do some independent computation on it, but its looking like this
may have been a combination of old software (win2k) and a bad corner case in
hardware.  I think the reporter has a NIC that doesn't do TCO properly on these
old style keepalives, which would explain why it wasn't reproducable outside of
the reporters environment.  I'm trying to figure out which card/hw revision of
NIC they were using.  It might be worth coding an errata check into the
appropriate driver if this all turns out to be accurate to disable TCO affectecd
hw.

Neil


  reply	other threads:[~2010-01-09  1:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06  0:39 BSD 4.2 style TCP keepalives David Miller
2010-01-06  2:07 ` Neil Horman
2010-01-06  3:59   ` David Miller
2010-01-06 17:21     ` Rick Jones
2010-01-06 20:50       ` Neil Horman
2010-01-06  8:23 ` David Miller
2010-01-06 23:04   ` David Miller
2010-01-07  0:14     ` David Miller
2010-01-07  3:21       ` David Miller
2010-01-07  3:36         ` David Miller
2010-01-07  0:34     ` Ilpo Järvinen
2010-01-07  0:59       ` David Miller
2010-01-07  7:55         ` Ilpo Järvinen
2010-01-08 12:40 ` Neil Horman
2010-01-08 21:21   ` David Miller
2010-01-09  1:22     ` Neil Horman [this message]
2010-01-09  1:41       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100109012227.GA2762@localhost.localdomain \
    --to=nhorman@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).