From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, gospo@redhat.com,
Greg Rose <gregory.v.rose@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next-2.6 PATCH 13/13] ixgbe: Fix ethtool diag test for VT mode operation
Date: Sat, 09 Jan 2010 04:27:05 -0800 [thread overview]
Message-ID: <20100109122704.4462.60493.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100109120719.4462.66489.stgit@localhost.localdomain>
From: Greg Rose <gregory.v.rose@intel.com>
Skip MAC loopback test when the adapter is set to a VT mode such as SR-IOV
or VMDq
Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_ethtool.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c
index 0bd49d3..a0107b5 100644
--- a/drivers/net/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ixgbe/ixgbe_ethtool.c
@@ -1867,11 +1867,22 @@ static void ixgbe_diag_test(struct net_device *netdev,
if (ixgbe_intr_test(adapter, &data[2]))
eth_test->flags |= ETH_TEST_FL_FAILED;
+ /* If SRIOV or VMDq is enabled then skip MAC
+ * loopback diagnostic. */
+ if (adapter->flags & (IXGBE_FLAG_SRIOV_ENABLED |
+ IXGBE_FLAG_VMDQ_ENABLED)) {
+ DPRINTK(HW, INFO, "Skip MAC loopback diagnostic in VT "
+ "mode\n");
+ data[3] = 0;
+ goto skip_loopback;
+ }
+
ixgbe_reset(adapter);
DPRINTK(HW, INFO, "loopback testing starting\n");
if (ixgbe_loopback_test(adapter, &data[3]))
eth_test->flags |= ETH_TEST_FL_FAILED;
+skip_loopback:
ixgbe_reset(adapter);
clear_bit(__IXGBE_TESTING, &adapter->state);
next prev parent reply other threads:[~2010-01-09 12:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-09 12:22 [net-next-2.6 PATCH 00/13] virtual function ixgbe driver Jeff Kirsher
2010-01-09 12:23 ` [net-next-2.6 PATCH 01/13] ixgbevf: Macros, data structures, useful defines and registers Jeff Kirsher
2010-01-09 12:23 ` [net-next-2.6 PATCH 02/13] ixgbevf: 82599 Virtual Function core functions and header Jeff Kirsher
2010-01-09 12:23 ` [net-next-2.6 PATCH 03/13] ixgbevf: Mailbox communication Jeff Kirsher
2010-01-09 12:24 ` [net-next-2.6 PATCH 04/13] ixgbevf: Driver main and ethool interface module and main header Jeff Kirsher
2010-01-09 12:24 ` [net-next-2.6 PATCH 05/13] ixgbevf: Driver Makefile Jeff Kirsher
2010-01-09 12:24 ` [net-next-2.6 PATCH 06/13] ixgbevf: Kconfig, Makefile and Documentation Jeff Kirsher
2010-01-09 12:25 ` [net-next-2.6 PATCH 07/13] ixgbe: Mailbox header and code module Jeff Kirsher
2010-01-09 12:25 ` [net-next-2.6 PATCH 08/13] ixgbe: Add SR-IOV register, structure and bit defines Jeff Kirsher
2010-01-09 12:25 ` [net-next-2.6 PATCH 09/13] ixgbe: Add SR-IOV specific features Jeff Kirsher
2010-01-09 12:26 ` [net-next-2.6 PATCH 10/13] ixgbe: Add SR-IOV specific modules to driver Makefile Jeff Kirsher
2010-01-09 12:26 ` [net-next-2.6 PATCH 11/13] ixgbe: Add SR-IOV feature enablement code Jeff Kirsher
2010-01-09 12:26 ` [net-next-2.6 PATCH 12/13] ixgbe: Add SR-IOV features to main module Jeff Kirsher
2010-01-09 12:27 ` Jeff Kirsher [this message]
2010-01-10 21:35 ` [net-next-2.6 PATCH 00/13] virtual function ixgbe driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100109122704.4462.60493.stgit@localhost.localdomain \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).