From: David Miller <davem@davemloft.net>
To: lorenzo@google.com
Cc: zenczykowski@gmail.com, therbert@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] IPv6: fix rt_lookup in pmtu_discovery
Date: Sun, 10 Jan 2010 13:15:24 -0800 (PST) [thread overview]
Message-ID: <20100110.131524.241344047.davem@davemloft.net> (raw)
In-Reply-To: <b91784ff1001081612g7c15e968u5e77931289af25c@mail.gmail.com>
From: Lorenzo Colitti <lorenzo@google.com>
Date: Fri, 8 Jan 2010 16:12:55 -0800
> How about this patch instead?
It's still not fully correct.
You can't ignore source based routing and pretend it doesn't
exist or matter.
That's why ipv4 (and this code you are trying to change) needs to
iterate over saddr [ ANY, saddr ], and that's why you need that
special loop that iterates over all combinations of ifindex/saddr.
This is what I've been asking you to do from the beginning, please
implement it this way and I'll apply your patch.
next prev parent reply other threads:[~2010-01-10 21:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 4:43 [PATCH] IPv6: fix rt_lookup in pmtu_discovery Tom Herbert
2010-01-07 9:27 ` David Miller
2010-01-08 1:05 ` Maciej Żenczykowski
2010-01-08 1:10 ` David Miller
2010-01-09 0:12 ` Lorenzo Colitti
2010-01-10 21:15 ` David Miller [this message]
2010-01-14 0:51 ` Maciej Żenczykowski
2010-01-20 22:55 ` Maciej Żenczykowski
2010-01-20 22:57 ` David Miller
2010-01-20 23:33 ` Maciej Żenczykowski
2010-01-23 10:20 ` David Miller
2010-09-27 10:05 ` [PATCH] net: Fix IPv6 PMTU disc. w/ asymmetric routes Maciej Żenczykowski
[not found] ` <AANLkTikPOHy79E1ZG=iJ-rHj0vzS+AY-mGqCEtWoXp2o@mail.gmail.com>
2010-09-27 18:11 ` David Miller
2010-09-28 20:58 ` David Miller
2010-09-28 22:37 ` Maciej Żenczykowski
2010-09-30 7:41 ` David Miller
2010-10-03 21:49 ` David Miller
2010-10-04 0:21 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100110.131524.241344047.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).