From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] NET: ipv6, fix potential null dereference
Date: Sun, 10 Jan 2010 12:47:42 +0200 [thread overview]
Message-ID: <20100110104742.GC4769@x200> (raw)
In-Reply-To: <4B49AE41.5000206@gmail.com>
On Sun, Jan 10, 2010 at 11:38:57AM +0100, Jiri Slaby wrote:
> On 01/10/2010 11:35 AM, Alexey Dobriyan wrote:
> >> Stanse found a potential null dereference
> >
> > Nobody learns from Coverity, it seems. :^)
>
> If it is known, why the test is still there?
>
> I don't have access to the Coverity results anyway.
Well, when Coverity first exposed their database there were innumerable
"potential NULL dereference" defects and people fixed them by moving
stuff and most were bogus and there were flamewars and there were second
wave and so on...
Apparently "check all callers" is very hard to do programmatically.
> > snmp6_unregister_dev() always called with valid idev.
irda patch is not right too: calling tty->ops->hook with NULL tty is
impossible.
next prev parent reply other threads:[~2010-01-10 10:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 10:35 [PATCH 1/1] NET: ipv6, fix potential null dereference Alexey Dobriyan
2010-01-10 10:38 ` Jiri Slaby
2010-01-10 10:47 ` Alexey Dobriyan [this message]
2010-01-10 11:05 ` Jiri Slaby
2010-01-10 11:37 ` Jiri Slaby
2010-01-10 10:43 ` [PATCH 1/1] NET: ipv6, remove unnecessary check Jiri Slaby
2010-01-10 21:28 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-01-10 9:06 [PATCH 1/1] NET: ipv6, fix potential null dereference Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100110104742.GC4769@x200 \
--to=adobriyan@gmail.com \
--cc=jirislaby@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).