From: Jarek Poplawski <jarkao2@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: mbreuer@majjas.com, shemminger@vyatta.com,
akpm@linux-foundation.org, flyboy@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6 resent] af_packet: Don't use skb after dev_queue_xmit()
Date: Sun, 10 Jan 2010 23:21:29 +0100 [thread overview]
Message-ID: <20100110222129.GA3606@del.dom.local> (raw)
In-Reply-To: <20100110.135135.237364018.davem@davemloft.net>
On Sun, Jan 10, 2010 at 01:51:35PM -0800, David Miller wrote:
> From: Jarek Poplawski <jarkao2@gmail.com>
> Date: Sat, 9 Jan 2010 13:38:27 +0100
>
> > tpacket_snd() can change and kfree an skb after dev_queue_xmit(),
> > which is illegal.
> >
> > With debugging by: Stephen Hemminger <shemminger@vyatta.com>
> >
> > Reported-by: Michael Breuer <mbreuer@majjas.com>
> > Tested-by: Michael Breuer <mbreuer@majjas.com>
> > Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
> > Acked-by: Stephen Hemminger <shemminger@vyatta.com>
>
> Jarek, if this code path triggers, it will deadlock the
> send ring with your changes.
>
> We will now leave the ring packet status in the "SENDING" state.
>
> That's not right.
No, the destructor of this skb, tpacket_destruct_skb(), will clean
this. (Just like for other skbs kfreed during dev_queue_xmit().)
Jarek P.
next prev parent reply other threads:[~2010-01-10 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-09 12:38 [PATCH net-2.6 resent] af_packet: Don't use skb after dev_queue_xmit() Jarek Poplawski
2010-01-10 21:51 ` David Miller
2010-01-10 22:21 ` Jarek Poplawski [this message]
2010-01-11 8:04 ` [PATCH net-2.6 alt.3] " Jarek Poplawski
2010-01-11 22:30 ` Michael Breuer
2010-01-11 22:48 ` Jarek Poplawski
2010-01-11 23:07 ` David Miller
2010-01-11 23:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100110222129.GA3606@del.dom.local \
--to=jarkao2@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=flyboy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbreuer@majjas.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).