From: David Miller <davem@davemloft.net>
To: ron.mercer@qlogic.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH 0/8] qlge: Add firmware coredump functionality.
Date: Mon, 11 Jan 2010 22:22:02 -0800 (PST) [thread overview]
Message-ID: <20100111.222202.66778648.davem@davemloft.net> (raw)
In-Reply-To: <1263258785-5112-1-git-send-email-ron.mercer@qlogic.com>
From: Ron Mercer <ron.mercer@qlogic.com>
Date: Mon, 11 Jan 2010 17:12:57 -0800
> Dump all regsiters and on chip RAM when a fatal firmware error is
> encountered. This features is turn on by default but can be
> turned off with a module parameter.
There is no way you should crap into someone's kernel log
with a large amount of information by default.
Yes, this is true even on fatal errors.
If you can't dump the information in say a dozen lines, it
is more trouble than it's worth as a default.
Make the default to off. Users can be asked to turn it on
if you need to capture more information for diagnostics,
and you personally can turn it on by default when doing
development.
Thanks.
next prev parent reply other threads:[~2010-01-12 6:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 1:12 [net-next PATCH 0/8] qlge: Add firmware coredump functionality Ron Mercer
2010-01-12 1:12 ` [net-next PATCH 1/8] qlge: Add data for firmware dump Ron Mercer
2010-01-12 6:20 ` David Miller
2010-01-12 1:12 ` [net-next PATCH 2/8] qlge: Add basic " Ron Mercer
2010-01-12 1:13 ` [net-next PATCH 3/8] qlge: Add probe regs to " Ron Mercer
2010-01-12 1:13 ` [net-next PATCH 4/8] qlge: Add RAM dump " Ron Mercer
2010-01-12 1:13 ` [net-next PATCH 5/8] qlge: Add alternate function's reg dump to fw dump Ron Mercer
2010-01-12 1:13 ` [net-next PATCH 6/8] qlge: Add serdes reg dump to firmware dump Ron Mercer
2010-01-12 1:13 ` [net-next PATCH 7/8] qlge: Add xgmac regs to firwmare dump Ron Mercer
2010-01-12 1:13 ` [net-next PATCH 8/8] qlge: Add option to force firmware core dump Ron Mercer
2010-01-12 6:22 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-15 23:31 [net-next PATCH 0/8] qlge: Add firmware coredump functionality Ron Mercer
2010-01-16 9:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100111.222202.66778648.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).