From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Matt Carlson" Subject: Re: tg3 appears to be sick in 2.6.33 Date: Mon, 11 Jan 2010 09:59:11 -0800 Message-ID: <20100111175911.GA10496@xw6200.broadcom.net> References: <20100108180915.GA8218@xw6200.broadcom.net> <201001081025.50298.dmitry.torokhov@gmail.com> <20100108194222.GA8386@xw6200.broadcom.net> <20100110.135242.113292015.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: "Matthew Carlson" , "dmitry.torokhov@gmail.com" , "eric.dumazet@gmail.com" , "netdev@vger.kernel.org" , "jfeeney@redhat.com" To: "David Miller" Return-path: Received: from mms2.broadcom.com ([216.31.210.18]:2817 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890Ab0AKR7V (ORCPT ); Mon, 11 Jan 2010 12:59:21 -0500 In-Reply-To: <20100110.135242.113292015.davem@davemloft.net> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Jan 10, 2010 at 01:52:42PM -0800, David Miller wrote: > From: "Matt Carlson" > Date: Fri, 8 Jan 2010 11:42:22 -0800 > > > [PATCH] tg3: Fix std rx prod ring handling > > > > There are some tg3 devices that require the driver to post new rx > > buffers in smaller increments. Commit > > 4361935afe3abc3e5a93006b99197fac1fabbd50, "tg3: Consider > > rx_std_prod_idx a hw mailbox" changed how the driver tracks the rx > > producer ring updates, but it does not make any special considerations > > for the above-mentioned devices. For those devices, it is possible for > > the driver to hit the special case path, which updates the hardware > > mailbox register but skips updating the shadow software mailbox member. > > If the special case path represents the final mailbox update for this > > ISR iteration, the hardware and software mailbox values will be out of > > sync. Ultimately, this will cause the driver to use a stale mailbox > > value on the next iteration, which will appear to the hardware as a > > large rx buffer update. Bad things ensue. > > > > The fix is to update the software shadow mailbox member when the special > > case path is taken. > > > > Signed-off-by: Matt Carlson > > Matt, since we have positive testing, want me to apply this? I have a small patchset queued up for net-2.6. Let me just include this one into the mix and submit it all at once.