From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: [PATCH net-2.6 alt.3] af_packet: Don't use skb after dev_queue_xmit() Date: Mon, 11 Jan 2010 23:48:17 +0100 Message-ID: <20100111224817.GB3369@del.dom.local> References: <20100111080419.GA6061@ff.dom.local> <4B4BA695.7040803@majjas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , shemminger@vyatta.com, akpm@linux-foundation.org, flyboy@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Michael Breuer Return-path: Received: from mail-fx0-f225.google.com ([209.85.220.225]:61821 "EHLO mail-fx0-f225.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895Ab0AKWsW (ORCPT ); Mon, 11 Jan 2010 17:48:22 -0500 Content-Disposition: inline In-Reply-To: <4B4BA695.7040803@majjas.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jan 11, 2010 at 05:30:45PM -0500, Michael Breuer wrote: > On 1/11/2010 3:04 AM, Jarek Poplawski wrote: ... > >----------------> (alternative 3) > > > >Subject: af_packet: Don't use skb after dev_queue_xmit() > > > >tpacket_snd() can change and kfree an skb after dev_queue_xmit(), > >which is illegal. > > > >With debugging by: Stephen Hemminger > > > >Reported-by: Michael Breuer > >Signed-off-by: Jarek Poplawski > > > >Cc: Stephen Hemminger > >--- > > > > net/packet/af_packet.c | 19 ++++++++++++++----- > > 1 files changed, 14 insertions(+), 5 deletions(-) ... > Tested by: Michael Breuer > > Note: This patch is delivering better ethernet throughput (15-20%) > and no than the previous two patches. I'm also no longer seeing > dropped RX packets. Good work! David, if this patch is acceptable now, please add: With help from: David S. Miller Tested-by: Michael Breuer Thanks everybody, Jarek P.