* Re: linux-next: Tree for January 8 (net/ip.h, BUG=n) [not found] <20100108164232.d3e1a164.sfr@canb.auug.org.au> @ 2010-01-08 17:25 ` Randy Dunlap 2010-01-13 7:35 ` Ingo Molnar 0 siblings, 1 reply; 6+ messages in thread From: Randy Dunlap @ 2010-01-08 17:25 UTC (permalink / raw) To: Stephen Rothwell, netdev; +Cc: linux-next, LKML, Arnd Bergmann On Fri, 8 Jan 2010 16:42:32 +1100 Stephen Rothwell wrote: > Hi all, > > Changes since 20100107: When CONFIG_BUG=n, CONFIG_GENERIC_BUG=n: include/net/ip.h:341: error: implicit declaration of function '__WARN' This affects: make[3]: *** [security/selinux/hooks.o] Error 1 make[3]: *** [fs/ceph/messenger.o] Error 1 make[3]: *** [net/core/sock.o] Error 1 make[4]: *** [drivers/net/benet/be_main.o] Error 1 (this was on i386 builds) --- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for January 8 (net/ip.h, BUG=n) 2010-01-08 17:25 ` linux-next: Tree for January 8 (net/ip.h, BUG=n) Randy Dunlap @ 2010-01-13 7:35 ` Ingo Molnar 2010-01-13 8:54 ` Jarek Poplawski 0 siblings, 1 reply; 6+ messages in thread From: Ingo Molnar @ 2010-01-13 7:35 UTC (permalink / raw) To: Randy Dunlap, David S. Miller Cc: Stephen Rothwell, netdev, linux-next, LKML, Arnd Bergmann * Randy Dunlap <randy.dunlap@oracle.com> wrote: > On Fri, 8 Jan 2010 16:42:32 +1100 Stephen Rothwell wrote: > > > Hi all, > > > > Changes since 20100107: > > > When CONFIG_BUG=n, CONFIG_GENERIC_BUG=n: > > include/net/ip.h:341: error: implicit declaration of function '__WARN' > > This affects: > make[3]: *** [security/selinux/hooks.o] Error 1 > make[3]: *** [fs/ceph/messenger.o] Error 1 > make[3]: *** [net/core/sock.o] Error 1 > make[4]: *** [drivers/net/benet/be_main.o] Error 1 FYI, this new build bug is now upstream and triggers in -tip testing as well. Ingo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for January 8 (net/ip.h, BUG=n) 2010-01-13 7:35 ` Ingo Molnar @ 2010-01-13 8:54 ` Jarek Poplawski 2010-01-13 19:21 ` Octavian Purdila 0 siblings, 1 reply; 6+ messages in thread From: Jarek Poplawski @ 2010-01-13 8:54 UTC (permalink / raw) To: Ingo Molnar Cc: Randy Dunlap, David S. Miller, Stephen Rothwell, netdev, linux-next, LKML, Arnd Bergmann, Octavian Purdila Octavian added to cc. Jarek P. On 13-01-2010 08:35, Ingo Molnar wrote: > * Randy Dunlap <randy.dunlap@oracle.com> wrote: > >> On Fri, 8 Jan 2010 16:42:32 +1100 Stephen Rothwell wrote: >> >>> Hi all, >>> >>> Changes since 20100107: >> >> When CONFIG_BUG=n, CONFIG_GENERIC_BUG=n: >> >> include/net/ip.h:341: error: implicit declaration of function '__WARN' >> >> This affects: >> make[3]: *** [security/selinux/hooks.o] Error 1 >> make[3]: *** [fs/ceph/messenger.o] Error 1 >> make[3]: *** [net/core/sock.o] Error 1 >> make[4]: *** [drivers/net/benet/be_main.o] Error 1 > > FYI, this new build bug is now upstream and triggers in -tip testing as well. > > Ingo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for January 8 (net/ip.h, BUG=n) 2010-01-13 8:54 ` Jarek Poplawski @ 2010-01-13 19:21 ` Octavian Purdila 2010-01-14 2:11 ` David Miller 2010-01-14 15:32 ` Randy Dunlap 0 siblings, 2 replies; 6+ messages in thread From: Octavian Purdila @ 2010-01-13 19:21 UTC (permalink / raw) To: David S. Miller Cc: Jarek Poplawski, Ingo Molnar, Randy Dunlap, Stephen Rothwell, netdev, linux-next, LKML, Arnd Bergmann On Wednesday 13 January 2010 10:54:18 you wrote: > Octavian added to cc. > > Jarek P. > > On 13-01-2010 08:35, Ingo Molnar wrote: > > * Randy Dunlap <randy.dunlap@oracle.com> wrote: > >> On Fri, 8 Jan 2010 16:42:32 +1100 Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Changes since 20100107: > >> > >> When CONFIG_BUG=n, CONFIG_GENERIC_BUG=n: > >> > >> include/net/ip.h:341: error: implicit declaration of function '__WARN' > >> > >> This affects: > >> make[3]: *** [security/selinux/hooks.o] Error 1 > >> make[3]: *** [fs/ceph/messenger.o] Error 1 > >> make[3]: *** [net/core/sock.o] Error 1 > >> make[4]: *** [drivers/net/benet/be_main.o] Error 1 > > > > FYI, this new build bug is now upstream and triggers in -tip testing as > > well. > > > > Ingo > Sorry about this bug and the delay. David, here is a patch against net-2.6 to fix this build error. [PATCH] net: fix build erros with CONFIG_BUG=n, CONFIG_GENERIC_BUG=n Fixed build errors introduced by commit 7ad6848c (ip: fix mc_loop checks for tunnels with multicast outer addresses) Signed-off-by: Octavian Purdila <opurdila@ixiacom.com> --- include/net/ip.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/net/ip.h b/include/net/ip.h index d9a0e74..fb63371 100644 --- a/include/net/ip.h +++ b/include/net/ip.h @@ -338,7 +338,7 @@ static inline int sk_mc_loop(struct sock *sk) return inet6_sk(sk)->mc_loop; #endif } - __WARN(); + WARN_ON(1); return 1; } -- 1.5.6.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for January 8 (net/ip.h, BUG=n) 2010-01-13 19:21 ` Octavian Purdila @ 2010-01-14 2:11 ` David Miller 2010-01-14 15:32 ` Randy Dunlap 1 sibling, 0 replies; 6+ messages in thread From: David Miller @ 2010-01-14 2:11 UTC (permalink / raw) To: opurdila Cc: jarkao2, mingo, randy.dunlap, sfr, netdev, linux-next, linux-kernel, arnd From: Octavian Purdila <opurdila@ixiacom.com> Date: Wed, 13 Jan 2010 21:21:44 +0200 > [PATCH] net: fix build erros with CONFIG_BUG=n, CONFIG_GENERIC_BUG=n > > Fixed build errors introduced by commit 7ad6848c (ip: fix mc_loop checks for > tunnels with multicast outer addresses) > > Signed-off-by: Octavian Purdila <opurdila@ixiacom.com> Applied, thanks. Let's make sure netdev is CC:'d on networking patches next time. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for January 8 (net/ip.h, BUG=n) 2010-01-13 19:21 ` Octavian Purdila 2010-01-14 2:11 ` David Miller @ 2010-01-14 15:32 ` Randy Dunlap 1 sibling, 0 replies; 6+ messages in thread From: Randy Dunlap @ 2010-01-14 15:32 UTC (permalink / raw) To: Octavian Purdila Cc: David S. Miller, Jarek Poplawski, Ingo Molnar, Stephen Rothwell, netdev, linux-next, LKML, Arnd Bergmann On Wed, 13 Jan 2010 21:21:44 +0200 Octavian Purdila wrote: > On Wednesday 13 January 2010 10:54:18 you wrote: > > Octavian added to cc. > > > > Jarek P. > > > > On 13-01-2010 08:35, Ingo Molnar wrote: > > > * Randy Dunlap <randy.dunlap@oracle.com> wrote: > > >> On Fri, 8 Jan 2010 16:42:32 +1100 Stephen Rothwell wrote: > > >>> Hi all, > > >>> > > >>> Changes since 20100107: > > >> > > >> When CONFIG_BUG=n, CONFIG_GENERIC_BUG=n: > > >> > > >> include/net/ip.h:341: error: implicit declaration of function '__WARN' > > >> > > >> This affects: > > >> make[3]: *** [security/selinux/hooks.o] Error 1 > > >> make[3]: *** [fs/ceph/messenger.o] Error 1 > > >> make[3]: *** [net/core/sock.o] Error 1 > > >> make[4]: *** [drivers/net/benet/be_main.o] Error 1 > > > > > > FYI, this new build bug is now upstream and triggers in -tip testing as > > > well. > > > > > > Ingo > > > > Sorry about this bug and the delay. David, here is a patch against net-2.6 to fix this build error. > > [PATCH] net: fix build erros with CONFIG_BUG=n, CONFIG_GENERIC_BUG=n > > Fixed build errors introduced by commit 7ad6848c (ip: fix mc_loop checks for > tunnels with multicast outer addresses) > > Signed-off-by: Octavian Purdila <opurdila@ixiacom.com> > --- > include/net/ip.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/net/ip.h b/include/net/ip.h > index d9a0e74..fb63371 100644 > --- a/include/net/ip.h > +++ b/include/net/ip.h > @@ -338,7 +338,7 @@ static inline int sk_mc_loop(struct sock *sk) > return inet6_sk(sk)->mc_loop; > #endif > } > - __WARN(); > + WARN_ON(1); > return 1; > } > > -- Acked-by: Randy Dunlap <randy.dunlap@oracle.com> Thanks. --- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-01-14 15:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100108164232.d3e1a164.sfr@canb.auug.org.au>
2010-01-08 17:25 ` linux-next: Tree for January 8 (net/ip.h, BUG=n) Randy Dunlap
2010-01-13 7:35 ` Ingo Molnar
2010-01-13 8:54 ` Jarek Poplawski
2010-01-13 19:21 ` Octavian Purdila
2010-01-14 2:11 ` David Miller
2010-01-14 15:32 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).