netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [net-2.6 PATCH 1/2] ixgbe: Do not attempt to perform interrupts in netpoll when down
@ 2010-01-13 11:49 Jeff Kirsher
  2010-01-13 11:49 ` [net-2.6 PATCH 2/2] ixgbe: update copyright dates Jeff Kirsher
  2010-01-14  1:15 ` [net-2.6 PATCH 1/2] ixgbe: Do not attempt to perform interrupts in netpoll when down David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Jeff Kirsher @ 2010-01-13 11:49 UTC (permalink / raw)
  To: davem
  Cc: netdev, gospo, Alexander Duyck, Mallikarjuna R Chilakala,
	Jeff Kirsher

From: Alexander Duyck <alexander.h.duyck@intel.com>

This patch resolves issues seen when running netconsole and rebooting via
reboot -f.  The issue was due to the fact that we were attempting to
perform interrupt actions when the q_vectors and rings had already been
freed via the ixgbe_shutdown routines.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Acked-by:  Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---

 drivers/net/ixgbe/ixgbe_main.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 2ad754c..3859767 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -5576,6 +5576,10 @@ static void ixgbe_netpoll(struct net_device *netdev)
 	struct ixgbe_adapter *adapter = netdev_priv(netdev);
 	int i;
 
+	/* if interface is down do nothing */
+	if (test_bit(__IXGBE_DOWN, &adapter->state))
+		return;
+
 	adapter->flags |= IXGBE_FLAG_IN_NETPOLL;
 	if (adapter->flags & IXGBE_FLAG_MSIX_ENABLED) {
 		int num_q_vectors = adapter->num_msix_vectors - NON_Q_VECTORS;


^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-14  1:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-13 11:49 [net-2.6 PATCH 1/2] ixgbe: Do not attempt to perform interrupts in netpoll when down Jeff Kirsher
2010-01-13 11:49 ` [net-2.6 PATCH 2/2] ixgbe: update copyright dates Jeff Kirsher
2010-01-14  1:15   ` David Miller
2010-01-14  1:15 ` [net-2.6 PATCH 1/2] ixgbe: Do not attempt to perform interrupts in netpoll when down David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).