From: David Miller <davem@davemloft.net>
To: keil@b1-systems.de
Cc: tilman@imap.cc, adobriyan@gmail.com, akpm@linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [ISDN] proc_fops: convert drivers/isdn/ to seq_file
Date: Thu, 14 Jan 2010 03:01:15 -0800 (PST) [thread overview]
Message-ID: <20100114.030115.95450487.davem@davemloft.net> (raw)
In-Reply-To: <20100113.202952.01130510.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 13 Jan 2010 20:29:52 -0800 (PST)
> From: Karsten Keil <keil@b1-systems.de>
> Date: Thu, 14 Jan 2010 02:37:07 +0100
>
>> drivers/isdn/hardware/eicon/divasproc.c | 198
>> ++++++++++++++-----------------
>
> Long lines broken up, again...
And just in case there is any confusion.
Take a look at:
http://patchwork.ozlabs.org/patch/42844/
That patch is mangled, and that's what Karsten sent to the list.
Diff hunk header lines that quote the function which is being modified
are chopped up into multiple lines:
--------------------
@@ -2229,59 +2230,37 @@ static void lower_callback(unsigned int cmd, u32
contr, void *data)
--------------------
That is corrupted, and it won't apply. And that's what landed in my
mailbox for Karsten's posting too, so it's not like patchwork put that
newline there.
The amount of time and effort being expended for this trivial patch
submission is staggering!
next prev parent reply other threads:[~2010-01-14 11:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 0:25 [patch 1/2] proc_fops: convert drivers/isdn/ to seq_file akpm
2009-12-23 12:30 ` Tilman Schmidt
2010-01-05 21:19 ` Alexey Dobriyan
2010-01-10 18:42 ` Tilman Schmidt
2010-01-10 21:29 ` David Miller
2010-01-10 23:33 ` Karsten Keil
2010-01-14 1:37 ` [ISDN] " Karsten Keil
2010-01-14 1:53 ` David Miller
2010-01-14 2:39 ` Karsten Keil
2010-01-14 2:43 ` David Miller
2010-01-14 4:29 ` David Miller
2010-01-14 11:01 ` David Miller [this message]
2010-01-04 5:26 ` [patch 1/2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114.030115.95450487.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=keil@b1-systems.de \
--cc=netdev@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).