From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Networking Development Mailing List
<netdev@vger.kernel.org>
Subject: Re: [PATCH] [NET]: da.s_net not copied but assigned to itself in aarp_rcv()
Date: Thu, 14 Jan 2010 19:00:01 -0200 [thread overview]
Message-ID: <20100114210001.GE20221@ghostprotocols.net> (raw)
In-Reply-To: <4B4F7F4B.8000302@gmail.com>
Em Thu, Jan 14, 2010 at 09:32:11PM +0100, Roel Kluin escreveu:
> da.s_net was not copied but assigned to itself.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Looks right, must be there for ages...
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c
> index 9d4adfd..f2b3b56 100644
> --- a/net/appletalk/aarp.c
> +++ b/net/appletalk/aarp.c
> @@ -819,7 +819,7 @@ static int aarp_rcv(struct sk_buff *skb, struct net_device *dev,
> ma = &ifa->address;
> else { /* We need to make a copy of the entry. */
> da.s_node = sa.s_node;
> - da.s_net = da.s_net;
> + da.s_net = sa.s_net;
> ma = &da;
> }
>
next parent reply other threads:[~2010-01-14 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B4F7F4B.8000302@gmail.com>
2010-01-14 21:00 ` Arnaldo Carvalho de Melo [this message]
2010-01-15 9:49 ` [PATCH] [NET]: da.s_net not copied but assigned to itself in aarp_rcv() David Miller
2012-03-02 19:34 ` Jonathan Nieder
2012-06-09 7:07 ` [2.6.32.y] Re: [PATCH] appletalk:: " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114210001.GE20221@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).