From: Patrick Mullaney <pmullaney@novell.com>
To: alacrityvm-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, kaber@trash.net, arnd@arndb.de,
netdev@vger.kernel.org
Subject: [PATCH 3/3] macvlan: use rtnl_link_ops->dellink during unregister notications
Date: Thu, 14 Jan 2010 16:53:18 -0500 [thread overview]
Message-ID: <20100114215318.4958.97684.stgit@mimic.site> (raw)
In-Reply-To: <20100114215058.4958.87746.stgit@mimic.site>
Different macvlan device types will need to release resources in
their own type specific dellink operation. This change ensures they
will for unregister notifications on the lower level device.
Signed-off-by: Patrick Mullaney <pmullaney@novell.com>
---
drivers/net/macvlan.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 94bb135..a57faaa 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -570,7 +570,7 @@ static int macvlan_device_event(struct notifier_block *unused,
break;
case NETDEV_UNREGISTER:
list_for_each_entry_safe(vlan, next, &port->vlans, list)
- macvlan_dellink(vlan->dev);
+ vlan->dev->rtnl_link_ops->dellink(vlan->dev);
break;
}
return NOTIFY_DONE;
next prev parent reply other threads:[~2010-01-14 21:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 21:52 [PATCH 0/3] vbus: venet macvlan rt netlink changes Patrick Mullaney
2010-01-14 21:53 ` [PATCH 1/3] venet-macvlan: allow rt netlink to create venet macvlan devices Patrick Mullaney
2010-01-14 21:53 ` [PATCH 2/3] macvlan: add GRO bit to features mask Patrick Mullaney
2010-01-15 10:08 ` Patrick McHardy
2010-01-15 20:00 ` [PATCH] " Patrick Mullaney
2010-01-16 9:05 ` David Miller
2010-01-14 21:53 ` Patrick Mullaney [this message]
2010-02-01 12:53 ` [PATCH 0/3] vbus: venet macvlan rt netlink changes Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114215318.4958.97684.stgit@mimic.site \
--to=pmullaney@novell.com \
--cc=alacrityvm-devel@lists.sourceforge.net \
--cc=arnd@arndb.de \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).