netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Remove unused function - skb_frag_add_head
@ 2010-01-15  5:32 Krishna Kumar
  2010-01-15  8:40 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Krishna Kumar @ 2010-01-15  5:32 UTC (permalink / raw)
  To: davem; +Cc: netdev, Krishna Kumar

From: Krishna Kumar <krkumar2@in.ibm.com>

Remove unused function - skb_frag_add_head

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---
 include/linux/skbuff.h |    6 ------
 1 file changed, 6 deletions(-)

diff -ruNp org/include/linux/skbuff.h new/include/linux/skbuff.h
--- org/include/linux/skbuff.h	2009-12-29 18:29:33.000000000 +0530
+++ new/include/linux/skbuff.h	2009-12-29 18:30:06.000000000 +0530
@@ -1728,12 +1728,6 @@ static inline void skb_frag_list_init(st
 	skb_shinfo(skb)->frag_list = NULL;
 }
 
-static inline void skb_frag_add_head(struct sk_buff *skb, struct sk_buff *frag)
-{
-	frag->next = skb_shinfo(skb)->frag_list;
-	skb_shinfo(skb)->frag_list = frag;
-}
-
 #define skb_walk_frags(skb, iter)	\
 	for (iter = skb_shinfo(skb)->frag_list; iter; iter = iter->next)
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove unused function - skb_frag_add_head
  2010-01-15  5:32 [PATCH] Remove unused function - skb_frag_add_head Krishna Kumar
@ 2010-01-15  8:40 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-01-15  8:40 UTC (permalink / raw)
  To: krkumar2; +Cc: netdev

From: Krishna Kumar <krkumar2@in.ibm.com>
Date: Fri, 15 Jan 2010 11:02:05 +0530

> From: Krishna Kumar <krkumar2@in.ibm.com>
> 
> Remove unused function - skb_frag_add_head
> 
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>

It rounds out the abstractions for accessing the fragment list.

All uses of the frag list need to be converted to these things
so that we can finally change sk_buff to use struct list_head
instead of a by-hand linked list.

So I'm not applying this.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-15  8:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-15  5:32 [PATCH] Remove unused function - skb_frag_add_head Krishna Kumar
2010-01-15  8:40 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).