From: David Miller <davem@davemloft.net>
To: krkumar2@in.ibm.com
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com
Subject: Re: ixgbe: [RFC] [PATCH] Fix return of invalid txq
Date: Fri, 15 Jan 2010 00:43:05 -0800 (PST) [thread overview]
Message-ID: <20100115.004305.73783675.davem@davemloft.net> (raw)
In-Reply-To: <20100115053117.31513.82775.sendpatchset@krkumar2.in.ibm.com>
From: Krishna Kumar <krkumar2@in.ibm.com>
Date: Fri, 15 Jan 2010 11:01:17 +0530
> A developer had complained of getting lots of warnings:
>
> "eth16 selects TX queue 98, but real number of TX queues is 64"
>
> http://www.mail-archive.com/e1000-devel@lists.sourceforge.net/msg02200.html
>
> As there was no follow up on that bug, I am submitting this
> patch assuming that the other return points will not return
> invalid txq's, and also that this fixes the bug (not tested).
>
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Guys I'm really sick of seeing this bug. Stop assuming that the
platform has limitations that platforms you happen to work on have.
NR_CPUS can be 4096, so you must assume everywhere that
smp_processor_id() can return just about any number.
Modulo the damn thing, or similar.
Don't use tables or crap like that. We do like Krishna's scheme
in net/core/dev.c:skb_tx_hash(), and that's what we should do
here too.
Krishna's patch is therefore correct, and I don't want to hear
anything about "tables", unless you're going to add "tables"
to net/core/dev.c :-)
prev parent reply other threads:[~2010-01-15 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 5:31 ixgbe: [RFC] [PATCH] Fix return of invalid txq Krishna Kumar
2010-01-15 7:58 ` Waskiewicz Jr, Peter P
2010-01-15 8:44 ` David Miller
2010-01-15 9:00 ` Peter P Waskiewicz Jr
2010-01-15 9:06 ` David Miller
2010-01-16 10:53 ` Waskiewicz Jr, Peter P
2010-02-12 19:55 ` David Miller
2010-02-12 20:12 ` Peter P Waskiewicz Jr
2010-01-15 8:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100115.004305.73783675.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).