From: David Miller <davem@davemloft.net>
To: peter.p.waskiewicz.jr@intel.com
Cc: krkumar2@in.ibm.com, netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com
Subject: Re: ixgbe: [RFC] [PATCH] Fix return of invalid txq
Date: Fri, 15 Jan 2010 00:44:56 -0800 (PST) [thread overview]
Message-ID: <20100115.004456.15627093.davem@davemloft.net> (raw)
In-Reply-To: <F86E8680A7D9D74A99DC6345E35A692950158650@orsmsx503.amr.corp.intel.com>
From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Date: Thu, 14 Jan 2010 23:58:17 -0800
> I've been trying to find time to add something like igb has, with a
> tiny Tx lookup table that maps CPUs into a smaller set of Tx queues.
Why do you need "tables"? Just modulo the it, with whatever
optimizations you can come up with.
Or do we not have enough data references in the TX path already?
:-/
I would suggest getting rid of the table in IGB too.
Either "tables" are a good idea (I think they definitely are not)
or they are not. And whatever the decision is we should do it
consistently. net/core/dev.c doesn't use tables, it does the
subtraction modulo thing like Krishna does.
next prev parent reply other threads:[~2010-01-15 8:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 5:31 ixgbe: [RFC] [PATCH] Fix return of invalid txq Krishna Kumar
2010-01-15 7:58 ` Waskiewicz Jr, Peter P
2010-01-15 8:44 ` David Miller [this message]
2010-01-15 9:00 ` Peter P Waskiewicz Jr
2010-01-15 9:06 ` David Miller
2010-01-16 10:53 ` Waskiewicz Jr, Peter P
2010-02-12 19:55 ` David Miller
2010-02-12 20:12 ` Peter P Waskiewicz Jr
2010-01-15 8:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100115.004456.15627093.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).