From: David Miller <davem@davemloft.net>
To: simon.kagstrom@netinsight.net
Cc: krkumar2@in.ibm.com, ilpo.jarvinen@helsinki.fi,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [RFC] [PATCH] Optimize TCP sendmsg in favour of fast devices?
Date: Fri, 15 Jan 2010 01:04:50 -0800 (PST) [thread overview]
Message-ID: <20100115.010450.64181969.davem@davemloft.net> (raw)
In-Reply-To: <20100115100011.076505bf@marrow.netinsight.se>
From: Simon Kagstrom <simon.kagstrom@netinsight.net>
Date: Fri, 15 Jan 2010 10:00:11 +0100
> On Fri, 15 Jan 2010 00:52:24 -0800 (PST)
> David Miller <davem@davemloft.net> wrote:
>
>> > The same thing goes for via-velocity.c, it's turned on via ethtool
>> > though (ethtool_op_set_sg).
>>
>> Indeed, see my reply to Krishna's ethtool_op_set_sg() patch.
>>
>> I think it's a cruddy way to do things, SG ought to be on by
>> default always unless it is defective. And if it's defective
>> support should be removed entirely.
>
> I kept it off by default since I didn't see any big improvement in my
> tests (negative in some, positive in some). But I suppose you're
> right though.
Well, it has to provide significantly better performance for
sendfile() (especially wrt. cpu utilization) because we avoid the copy
out of the page cache pages entirely.
next prev parent reply other threads:[~2010-01-15 9:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 5:33 [RFC] [PATCH] Optimize TCP sendmsg in favour of fast devices? Krishna Kumar
2010-01-15 8:36 ` David Miller
2010-01-15 8:50 ` Simon Kagstrom
2010-01-15 8:52 ` David Miller
2010-01-15 9:00 ` Simon Kagstrom
2010-01-15 9:04 ` David Miller [this message]
2010-01-15 9:03 ` Krishna Kumar2
[not found] ` <OF1B0853DD.2824263E-ON652576AC.002FA9D4-652576AC.0030AC47@LocalDomain>
2010-01-15 9:20 ` Krishna Kumar2
2010-01-15 9:18 ` David Miller
2010-01-20 12:19 ` Krishna Kumar2
2010-01-21 9:25 ` David Miller
2010-01-21 9:41 ` Herbert Xu
2010-01-27 7:12 ` Krishna Kumar2
2010-01-29 9:06 ` Herbert Xu
2010-01-29 11:15 ` Krishna Kumar2
2010-01-29 11:33 ` Herbert Xu
2010-01-29 11:50 ` Krishna Kumar2
2010-01-29 20:02 ` Rick Jones
2010-01-29 19:56 ` Rick Jones
[not found] ` <OF7EA723DA.DC2FF4FC-ON652576B8.002064CB-652576B8.00267739@LocalDomain>
2010-01-27 9:42 ` Krishna Kumar2
2010-01-29 9:07 ` Herbert Xu
2010-01-15 18:13 ` Rick Jones
2010-01-16 6:38 ` Krishna Kumar2
2010-01-19 17:41 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100115.010450.64181969.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=simon.kagstrom@netinsight.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).