From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: christian.samsel@rwth-aachen.de, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] improve netem reorder flexibility
Date: Sat, 16 Jan 2010 01:46:54 -0800 (PST) [thread overview]
Message-ID: <20100116.014654.69913255.davem@davemloft.net> (raw)
In-Reply-To: <20091221095407.5430a630@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 21 Dec 2009 09:54:07 -0800
> The netem logic for parsing attributes is different from others for
> historical reasons. Looking at parse_attr():
>
> If qopt is larger than expected, then the extra data is interpreted as
> the following nested attribute.
>
> If qopt is smaller than expected, then it returns -EINVAL.
This is a really dangerous way to handle this.
This means if you grow qopt, older kernels think that the
extended area is attributes.
This also means that if you have new tools and send a qopt +
attributes, older kernels won't find the start of the attributes
correctly. It will miss the attributes entirely.
This is a complete mess, and we need to sort it out before we think
about changing the size of qopt at this point.
next prev parent reply other threads:[~2010-01-16 9:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 13:18 [PATCH 1/2] improve netem reorder flexibility Christian Samsel
2009-12-18 13:18 ` [PATCH 2/2] " Christian Samsel
2009-12-18 17:32 ` [PATCH 1/2] " Stephen Hemminger
2009-12-18 17:56 ` Christian Samsel
2009-12-18 18:01 ` Christian Samsel
2009-12-19 3:59 ` David Miller
2009-12-19 10:38 ` Christian Samsel
2009-12-21 17:54 ` Stephen Hemminger
2010-01-16 9:46 ` David Miller [this message]
2010-01-17 12:11 ` Christian Samsel
2010-01-18 2:56 ` David Miller
2010-01-18 5:44 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100116.014654.69913255.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christian.samsel@rwth-aachen.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).