From: David Miller <davem@davemloft.net>
To: ja@ssi.bg
Cc: opurdila@ixiacom.com, netdev@vger.kernel.org, chavey@google.com
Subject: Re: [PATCH v2] ipv4: support for request type gratuitous ARP
Date: Sun, 17 Jan 2010 19:05:40 -0800 (PST) [thread overview]
Message-ID: <20100117.190540.22362723.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.58.1001172213550.10728@u.domain.uli>
From: Julian Anastasov <ja@ssi.bg>
Date: Sun, 17 Jan 2010 22:43:54 +0200 (EET)
> Looks correct to me. You will save some CPU cycles
> if the 'arp->ar_op == htons(ARPOP_REQUEST)' check is not added.
> May be you also need to change arp_accept in
> Documentation/networking/ip-sysctl.txt to show that we do not
> differentiate Gratuitous ARP requests from replies.
Octavian, please make the documentation fix for 'arp_accept'
and resubmit your patch.
It otherwise looks fine to me now.
Thanks.
prev parent reply other threads:[~2010-01-18 3:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 22:04 [RFC] ipv4: support for request type gratuitous ARP Octavian Purdila
2010-01-06 20:24 ` Laurent Chavey
2010-01-10 21:21 ` David Miller
2010-01-11 21:31 ` Octavian Purdila
2010-01-16 22:18 ` [PATCH v2] " Octavian Purdila
2010-01-17 13:45 ` Julian Anastasov
2010-01-17 18:55 ` Octavian Purdila
2010-01-17 20:43 ` Julian Anastasov
2010-01-18 3:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100117.190540.22362723.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chavey@google.com \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).