From: Stephen Hemminger <shemminger@vyatta.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Tom Herbert <therbert@google.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v5] rps: Receive Packet Steering
Date: Sun, 17 Jan 2010 09:22:21 -0800 [thread overview]
Message-ID: <20100117092221.2fca789c@nehalam> (raw)
In-Reply-To: <1263607893.17815.114.camel@localhost>
On Sat, 16 Jan 2010 02:11:33 +0000
Ben Hutchings <bhutchings@solarflare.com> wrote:
> On Thu, 2010-01-14 at 14:56 -0800, Stephen Hemminger wrote:
> > On Thu, 14 Jan 2010 13:56:23 -0800 (PST)
> > Tom Herbert <therbert@google.com> wrote:
> [...]
> > > The CPU masks is set on a per device basis in the sysfs variable
> > > /sys/class/net/<device>/rps_cpus. This is a set of canonical bit maps for
> > > each NAPI nstance of the device. For example:
> > >
> > > echo "0b 0b0 0b00 0b000" > /sys/class/net/eth0/rps_cpus
> >
> > Why not make a kobject out of cpus which would add subdirectory.
> > This would keep interface consistent with the one value per file
> > semantic of sysfs.
>
> Do you mean a kobject per NAPI context, each initially with a rps_cpus
> attribute holding a CPU mask, or a kobject per CPU, each with an
> attribute specifying which NAPI contexts it does work for? (Personally
> I'd favour the first.)
Yes, make NAPI real kobjects, linked to device.
BUT
make sure this also handles case of N to 1 mapping as well
as 1 to N case.
next prev parent reply other threads:[~2010-01-17 17:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 21:56 [PATCH v5] rps: Receive Packet Steering Tom Herbert
2010-01-14 22:56 ` Stephen Hemminger
2010-01-14 23:31 ` Rick Jones
2010-01-16 2:11 ` Ben Hutchings
2010-01-17 17:22 ` Stephen Hemminger [this message]
2010-01-15 2:22 ` Changli Gao
2010-01-15 6:19 ` Eric Dumazet
2010-01-15 6:39 ` Changli Gao
2010-01-15 6:57 ` Eric Dumazet
2010-01-15 8:49 ` David Miller
2010-01-15 9:20 ` Changli Gao
2010-01-15 9:26 ` David Miller
2010-01-21 7:04 ` Changli Gao
2010-01-15 9:45 ` David Miller
2010-01-15 8:50 ` David Miller
2010-01-15 9:05 ` Changli Gao
2010-01-15 6:27 ` Eric Dumazet
2010-01-16 2:26 ` Ben Hutchings
2010-01-21 7:54 ` Changli Gao
2010-01-21 9:16 ` Eric Dumazet
2010-01-28 6:04 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100117092221.2fca789c@nehalam \
--to=shemminger@vyatta.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).