From: David Miller <davem@davemloft.net>
To: julia@diku.dk
Cc: ron.mercer@qlogic.com, linux-driver@qlogic.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/9] drivers/net: Eliminate useless code
Date: Mon, 18 Jan 2010 00:29:31 -0800 (PST) [thread overview]
Message-ID: <20100118.002931.55279267.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1001180911080.12648@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Mon, 18 Jan 2010 09:12:21 +0100 (CET)
> From: Julia Lawall <julia@diku.dk>
>
> The variable qdev is initialized twice to the same (side effect-free)
> expression. Drop one initialization.
>
> A simplified version of the semantic match that finds this problem is:
> (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied, thanks.
prev parent reply other threads:[~2010-01-18 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 15:57 [PATCH 3/9] drivers/net: Eliminate useless code Julia Lawall
2010-01-18 3:31 ` David Miller
2010-01-18 5:47 ` Julia Lawall
2010-01-18 8:12 ` Julia Lawall
2010-01-18 8:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118.002931.55279267.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).