* [PATCH 3/9] drivers/net: Eliminate useless code
@ 2010-01-16 15:57 Julia Lawall
2010-01-18 3:31 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2010-01-16 15:57 UTC (permalink / raw)
To: Ron Mercer, linux-driver, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The variable qdev is initialized twice to the same (side effect-free)
expression. Drop one initialization.
A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)
// <smpl>
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@
x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/qla3xxx.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index f922294..4ef0afb 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -4087,9 +4087,8 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev)
struct ql3_adapter *qdev = netdev_priv(ndev);
unregister_netdev(ndev);
- qdev = netdev_priv(ndev);
ql_disable_interrupts(qdev);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/9] drivers/net: Eliminate useless code
2010-01-16 15:57 [PATCH 3/9] drivers/net: Eliminate useless code Julia Lawall
@ 2010-01-18 3:31 ` David Miller
2010-01-18 5:47 ` Julia Lawall
2010-01-18 8:12 ` Julia Lawall
0 siblings, 2 replies; 5+ messages in thread
From: David Miller @ 2010-01-18 3:31 UTC (permalink / raw)
To: julia; +Cc: ron.mercer, linux-driver, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Sat, 16 Jan 2010 16:57:56 +0100 (CET)
> The variable qdev is initialized twice to the same (side effect-free)
> expression. Drop one initialization.
>
> A simplified version of the semantic match that finds this problem is:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @forall@
> idexpression *x;
> identifier f!=ERR_PTR;
> @@
>
> x = f(...)
> ... when != x
> (
> x = f(...,<+...x...+>,...)
> |
> * x = f(...)
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Something in your patch creation process is corrupting these
patches.
> diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
> index f922294..4ef0afb 100644
> --- a/drivers/net/qla3xxx.c
> +++ b/drivers/net/qla3xxx.c
> @@ -4087,9 +4087,8 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev)
> struct ql3_adapter *qdev = netdev_priv(ndev);
>
> unregister_netdev(ndev);
> - qdev = netdev_priv(ndev);
>
> ql_disable_interrupts(qdev);
>
> --
That hunk header states that after the line is removed there should
be 8 lines present in the hunk, but the patch only shows 7 such
lines.
I suspect something is eating the final line of your patches.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/9] drivers/net: Eliminate useless code
2010-01-18 3:31 ` David Miller
@ 2010-01-18 5:47 ` Julia Lawall
2010-01-18 8:12 ` Julia Lawall
1 sibling, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2010-01-18 5:47 UTC (permalink / raw)
To: David Miller
Cc: ron.mercer, linux-driver, netdev, linux-kernel, kernel-janitors
On Sun, 17 Jan 2010, David Miller wrote:
> From: Julia Lawall <julia@diku.dk>
> Date: Sat, 16 Jan 2010 16:57:56 +0100 (CET)
>
> > The variable qdev is initialized twice to the same (side effect-free)
> > expression. Drop one initialization.
> >
> > A simplified version of the semantic match that finds this problem is:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @forall@
> > idexpression *x;
> > identifier f!=ERR_PTR;
> > @@
> >
> > x = f(...)
> > ... when != x
> > (
> > x = f(...,<+...x...+>,...)
> > |
> > * x = f(...)
> > )
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <julia@diku.dk>
>
> Something in your patch creation process is corrupting these
> patches.
>
> > diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
> > index f922294..4ef0afb 100644
> > --- a/drivers/net/qla3xxx.c
> > +++ b/drivers/net/qla3xxx.c
> > @@ -4087,9 +4087,8 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev)
> > struct ql3_adapter *qdev = netdev_priv(ndev);
> >
> > unregister_netdev(ndev);
> > - qdev = netdev_priv(ndev);
> >
> > ql_disable_interrupts(qdev);
> >
> > --
>
> That hunk header states that after the line is removed there should
> be 8 lines present in the hunk, but the patch only shows 7 such
> lines.
>
> I suspect something is eating the final line of your patches.
Oops, sorry. I will try again. I'm surprised that checkpatch didn't
complain.
julia
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/9] drivers/net: Eliminate useless code
2010-01-18 3:31 ` David Miller
2010-01-18 5:47 ` Julia Lawall
@ 2010-01-18 8:12 ` Julia Lawall
2010-01-18 8:29 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2010-01-18 8:12 UTC (permalink / raw)
To: David Miller
Cc: ron.mercer, linux-driver, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The variable qdev is initialized twice to the same (side effect-free)
expression. Drop one initialization.
A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)
// <smpl>
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@
x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/qla3xxx.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index f922294..4ef0afb 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -4087,7 +4087,6 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev)
struct ql3_adapter *qdev = netdev_priv(ndev);
unregister_netdev(ndev);
- qdev = netdev_priv(ndev);
ql_disable_interrupts(qdev);
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-01-18 8:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-16 15:57 [PATCH 3/9] drivers/net: Eliminate useless code Julia Lawall
2010-01-18 3:31 ` David Miller
2010-01-18 5:47 ` Julia Lawall
2010-01-18 8:12 ` Julia Lawall
2010-01-18 8:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).