From: Greg KH <gregkh@suse.de>
To: Emese Revfy <re.emese@gmail.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-kernel@vger.kernel.org, teigland@redhat.com,
Matt_Domsch@dell.com, maciej.sosnowski@intel.com,
hjk@linutronix.de, Pekka Enberg <penberg@cs.helsinki.fi>,
jens.axboe@oracle.com, shemminger@vyatta.com,
akpm@linux-foundation.org, davem@davemloft.net,
torvalds@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] Constify struct sysfs_ops for v2.6.33-rc4
Date: Sun, 17 Jan 2010 17:35:21 -0800 [thread overview]
Message-ID: <20100118013521.GA4190@suse.de> (raw)
In-Reply-To: <4B536FF5.3000705@gmail.com>
On Sun, Jan 17, 2010 at 09:15:49PM +0100, Emese Revfy wrote:
> Al Viro wrote:
> > On Sun, Jan 17, 2010 at 05:20:38PM +0100, Emese Revfy wrote:
> >
> >> Signed-off-by: Emese Revfy <re.emese@gmail.com>
> >> Acked-by: David Teigland <teigland@redhat.com>
> >> Acked-by: Matt Domsch <Matt_Domsch@dell.com>
> >> Acked-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
> >> Acked-by: Hans J. Koch <hjk@linutronix.de>
> >> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> >> Acked-by: Jens Axboe <jens.axboe@oracle.com>
> >> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
> >
> > NACKed-by: Al Viro <viro@zeniv.linux.org.uk>
> >
> > Same reason.
> >
> >> - ssize_t (*show)(struct kobject *, struct attribute *, char *);
> >> - ssize_t (*store)(struct kobject *, struct attribute *, const char *);
> >> + ssize_t (* const show)(struct kobject *, struct attribute *, char *);
> >> + ssize_t (* const store)(struct kobject *, struct attribute *, const char *);
> >
>
> Ok, I removed the field constification, here's the updated patch:
Please resend with proper changelog and other information so that it
could be applied.
thanks,
greg k-h
next prev parent reply other threads:[~2010-01-18 1:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B5338D6.2050209@gmail.com>
2010-01-17 18:25 ` [PATCH 1/1] Constify struct sysfs_ops for v2.6.33-rc4 Al Viro
2010-01-17 18:29 ` Al Viro
2010-01-17 20:15 ` Emese Revfy
2010-01-17 20:15 ` Emese Revfy
2010-01-18 1:35 ` Greg KH [this message]
2010-01-19 1:58 ` Emese Revfy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118013521.GA4190@suse.de \
--to=gregkh@suse.de \
--cc=Matt_Domsch@dell.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hjk@linutronix.de \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.sosnowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=re.emese@gmail.com \
--cc=shemminger@vyatta.com \
--cc=teigland@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).