From: Hagen Paul Pfeifer <hagen@jauu.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: netdev@vger.kernel.org, kaber@trash.net, davem@davemloft.net
Subject: Re: [PATCH 1/1] sched: add head drop fifo queue
Date: Mon, 18 Jan 2010 20:36:45 +0100 [thread overview]
Message-ID: <20100118193645.GH16482@nuttenaction> (raw)
In-Reply-To: <4B54B59D.5010108@gmail.com>
* Jarek Poplawski | 2010-01-18 20:25:17 [+0100]:
>I don't think this is needed; qdisc_dequeue_head() updated it already.
No, the bookkeeping stuff is done in the previous call layer. It is not really
nice solved but to generalize this stuff adds unnecessary overhead.
>> + .drop = qdisc_queue_drop,
>
>Probably it isn't used much, but it seems for consistency this drop
>should be implemented as a head drop.
Sounds coherent, Patrick should I brew a new patch?
HGN
PS: Jarek thank you for your notes, I will incorporate these!
next prev parent reply other threads:[~2010-01-18 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 13:21 [PATCH 1/1] sched: add head drop fifo queue Hagen Paul Pfeifer
2010-01-18 14:24 ` Patrick McHardy
2010-01-18 16:27 ` Hagen Paul Pfeifer
2010-01-18 16:32 ` Hagen Paul Pfeifer
2010-01-18 16:30 ` Hagen Paul Pfeifer
2010-01-18 16:34 ` Patrick McHardy
2010-01-18 16:44 ` Hagen Paul Pfeifer
2010-01-18 19:25 ` Jarek Poplawski
2010-01-18 19:36 ` Hagen Paul Pfeifer [this message]
2010-01-18 19:51 ` Jarek Poplawski
2010-01-18 19:59 ` Hagen Paul Pfeifer
2010-01-18 20:27 ` [PATCH V2] " Hagen Paul Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118193645.GH16482@nuttenaction \
--to=hagen@jauu.net \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).