From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Tino Keitel <tino.keitel@tikei.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: Regression: Wake on LAN doesn't work in sky2 with 2.6.33-rc4-git2
Date: Mon, 18 Jan 2010 22:34:55 +0100 [thread overview]
Message-ID: <201001182234.55113.rjw@sisk.pl> (raw)
In-Reply-To: <20100118083757.GA2619@mac.home>
On Monday 18 January 2010, Tino Keitel wrote:
> Hi,
>
> reverting this commit fixes WoL for me:
>
> commit 166a0fd4c788ec7f10ca8194ec6d526afa12db75
> Author: stephen hemminger <shemminger@vyatta.com>
> Date: Mon Dec 14 08:50:12 2009 +0000
>
> sky2: leave PCI config space writeable
>
> Since power management is done by PCI subsystem as well as driver,
> don't toggle the bit that disables PCI register writes.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Hmm, this is kind of interesting.
Perhaps we clear the WoL setting somewhere we shouldn't, but the
"disable PCI register writes" bit prevents this from actually happening?
Rafael
next prev parent reply other threads:[~2010-01-18 21:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 9:10 Regression: Wake on LAN doesn't work in sky2 with 2.6.33-rc4-git2 Tino Keitel
2010-01-15 18:50 ` Stephen Hemminger
2010-01-15 22:23 ` Rafael J. Wysocki
2010-01-17 23:19 ` Tino Keitel
2010-01-18 0:36 ` Rafael J. Wysocki
2010-01-18 8:37 ` Tino Keitel
2010-01-18 11:59 ` Mike McCormack
2010-01-18 18:52 ` Tino Keitel
2010-01-18 19:52 ` Stephen Hemminger
2010-01-18 20:58 ` Tino Keitel
2010-01-18 21:34 ` Rafael J. Wysocki [this message]
2010-01-18 22:43 ` Stephen Hemminger
2010-01-19 10:32 ` Tino Keitel
2010-01-19 18:51 ` Stephen Hemminger
2010-01-19 19:37 ` Tino Keitel
2010-01-24 20:35 ` Rafael J. Wysocki
2010-01-25 4:42 ` Stephen Hemminger
2010-01-25 4:46 ` [PATCH] sky2: revert config space change Stephen Hemminger
2010-01-25 6:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001182234.55113.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=tino.keitel@tikei.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).