From: David Miller <davem@davemloft.net>
To: avorontsov@ru.mvista.com
Cc: nsekhar@ti.com, netdev@vger.kernel.org
Subject: Re: [PATCH] phylib: Move workqueue initialization to a proper place
Date: Tue, 19 Jan 2010 02:00:29 -0800 (PST) [thread overview]
Message-ID: <20100119.020029.55299562.davem@davemloft.net> (raw)
In-Reply-To: <20100118153716.GA30861@oksana.dev.rtsoft.ru>
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Mon, 18 Jan 2010 18:37:16 +0300
> commit 541cd3ee00a4fe975b22fac6a3bc846bacef37f7 ("phylib: Fix deadlock
> on resume") caused TI DaVinci EMAC ethernet driver to oops upon resume:
...
> The oops pops up because TI DaVinci EMAC driver detaches PHY on
> suspend and attaches it back on resume. Attaching makes phylib call
> phy_start_machine() that initializes a workqueue. On the other hand,
> PHY's resume routine will call phy_start_machine() again, and that
> will cause the oops since we just destroyed the already scheduled
> workqueue.
>
> This patch fixes the issue by moving workqueue initialization to
> phy_device_create().
>
> p.s. We don't see this oops with ucc_geth and gianfar drivers because
> they perform a fine-grained suspend, i.e. they just stop the PHYs
> without detaching.
>
> Reported-by: Sekhar Nori <nsekhar@ti.com>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Tested-by: Sekhar Nori <nsekhar@ti.com>
Applied, thanks.
prev parent reply other threads:[~2010-01-19 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 16:08 phylib: kernel oops on resume with 2.6.33-rc4 Nori, Sekhar
2010-01-16 22:37 ` Anton Vorontsov
2010-01-17 8:28 ` Nori, Sekhar
2010-01-18 3:23 ` David Miller
2010-01-18 15:37 ` [PATCH] phylib: Move workqueue initialization to a proper place Anton Vorontsov
2010-01-19 10:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119.020029.55299562.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avorontsov@ru.mvista.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).