From: David Miller <davem@davemloft.net>
To: lsorense@csclub.uwaterloo.ca
Cc: linux-kernel@vger.kernel.org, gabriele.paoloni@intel.com,
netdev@vger.kernel.org
Subject: Re: ppp_generic.c severly whitespace damanged by 9c705260feea6ae329bc6b6d5f6d2ef0227eda0a
Date: Tue, 19 Jan 2010 02:13:01 -0800 (PST) [thread overview]
Message-ID: <20100119.021301.228036686.davem@davemloft.net> (raw)
In-Reply-To: <20100118225955.GA24307@caffeine.csclub.uwaterloo.ca>
From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen)
Date: Mon, 18 Jan 2010 17:59:55 -0500
> I was just looking at ppp_generic, and noticed that it fairly recently
> (as in the last year) got rather mangled with many spaces turned into tabs
> in places they very much shouldn't have been. I tracked it down to commit
> 9c705260feea6ae329bc6b6d5f6d2ef0227eda0a (ppp: ppp_mp_explode() redesign).
>
> I am amazed if that patch passed the patch checking script. I have no
> idea what kind of weird editor setting did this, but it has to have been a
> weird editor setting or a very unfortunate search and replace gone wrong.
> I only found it trying to apply a patch I was playing with and wondering
> why it wouldn't apply. Then I found there were tabs in the middle of
> comments that used to be spaces.
>
> Well here is a patch that should fix it up as far as I can tell.
>
> Purely whitespace repair. No actual code changes.
>
> Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>
I'm probably responsible for not catching this sorry.
Applied to net-next-2.6, thanks.
next prev parent reply other threads:[~2010-01-19 10:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 22:59 ppp_generic.c severly whitespace damanged by 9c705260feea6ae329bc6b6d5f6d2ef0227eda0a Lennart Sorensen
2010-01-19 10:13 ` David Miller [this message]
2010-01-19 15:44 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119.021301.228036686.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gabriele.paoloni@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).