* Re: [PATCH net-2.6] S2io: two branches the same in wait_for_cmd_complete()
2010-01-19 21:20 [PATCH net-2.6] S2io: two branches the same in wait_for_cmd_complete() Ramkrishna Vepa
@ 2010-01-19 20:36 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-01-19 20:36 UTC (permalink / raw)
To: ram.vepa; +Cc: netdev, roel.kluin
From: Ramkrishna Vepa <ram.vepa@neterion.com>
Date: 19 Jan 2010 13:20:09 -0800
> Fix check to verify if a register bit is set. We have not hit this bug because
> wait_for_cmd_complete() is always called with S2IO_BIT_RESET.
> Reported by Roel Kluin <roel.kluin@gmail.com>.
>
> Signed-off-by: Ram Vepa <ram.vepa@neterion.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH net-2.6] S2io: two branches the same in wait_for_cmd_complete()
@ 2010-01-19 21:20 Ramkrishna Vepa
2010-01-19 20:36 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ramkrishna Vepa @ 2010-01-19 21:20 UTC (permalink / raw)
To: David Miller; +Cc: Netdev, roel.kluin
Fix check to verify if a register bit is set. We have not hit this bug because
wait_for_cmd_complete() is always called with S2IO_BIT_RESET.
Reported by Roel Kluin <roel.kluin@gmail.com>.
Signed-off-by: Ram Vepa <ram.vepa@neterion.com>
---
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index cc42186..3c4836d 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -3421,7 +3421,7 @@ static int wait_for_cmd_complete(void __iomem *addr, u64 busy_bit,
break;
}
} else {
- if (!(val64 & busy_bit)) {
+ if (val64 & busy_bit) {
ret = SUCCESS;
break;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-19 20:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-19 21:20 [PATCH net-2.6] S2io: two branches the same in wait_for_cmd_complete() Ramkrishna Vepa
2010-01-19 20:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).