From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next-2.6] IFix IPv6 GSO type checks in Intel ethernet drivers Date: Tue, 19 Jan 2010 14:14:38 -0800 (PST) Message-ID: <20100119.141438.266557246.davem@davemloft.net> References: <1263934927.1635.24.camel@w-sridhar.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sri@us.ibm.com, herbert@gondor.apana.org.au, jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org To: jesse.brandeburg@intel.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:34518 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755079Ab0ASWO2 (ORCPT ); Tue, 19 Jan 2010 17:14:28 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: "Brandeburg, Jesse" Date: Tue, 19 Jan 2010 13:11:00 -0800 (Pacific Standard Time) > > > On Tue, 19 Jan 2010, Sridhar Samudrala wrote: > >> Found this problem when testing IPv6 from a KVM guest to a remote >> host via e1000e device on the host. >> The following patch fixes the check for IPv6 GSO packet in Intel >> ethernet drivers to use skb_is_gso_v6(). SKB_GSO_DODGY is also set >> when packets are forwarded from a guest. >> >> Signed-off-by: Sridhar Samudrala > Looks fine, thanks! The current code in net-next and 2.6.32 both have > exactly the same condition in skb_is_gso_v6, so I'm not sure that this > patch alone will fix any issues, FYI. If this patch is part of another > set or dependent upon another for the actual change in behavior mentioned > in the comment, I think it should be noted or sent in a series. > > Ack-ed by: Jesse Brandeburg Just FYI, I'm assuming I'll get this via Jeff eventually.