* Re: linux-next: Tree for January 19 (vhost_net) [not found] <20100119181041.ab55f645.sfr@canb.auug.org.au> @ 2010-01-19 18:41 ` Randy Dunlap 2010-01-20 10:16 ` Michael S. Tsirkin 2010-01-20 11:33 ` Michael S. Tsirkin 0 siblings, 2 replies; 5+ messages in thread From: Randy Dunlap @ 2010-01-19 18:41 UTC (permalink / raw) To: Stephen Rothwell, netdev, Michael S. Tsirkin; +Cc: linux-next, LKML On Tue, 19 Jan 2010 18:10:41 +1100 Stephen Rothwell wrote: > Hi all, > > Changes since 20100118: When CONFIG_TUN is not enabled: drivers/built-in.o: In function `get_socket': net.c:(.text+0x2899a3): undefined reference to `tun_get_socket' so VHOST_NET can either depend on TUN or select TUN, but if it selects TUN, it will also need to select CRC32. --- ~Randy ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for January 19 (vhost_net) 2010-01-19 18:41 ` linux-next: Tree for January 19 (vhost_net) Randy Dunlap @ 2010-01-20 10:16 ` Michael S. Tsirkin 2010-01-20 11:37 ` Stephen Rothwell 2010-01-20 11:33 ` Michael S. Tsirkin 1 sibling, 1 reply; 5+ messages in thread From: Michael S. Tsirkin @ 2010-01-20 10:16 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, netdev, linux-next, LKML On Tue, Jan 19, 2010 at 10:41:39AM -0800, Randy Dunlap wrote: > On Tue, 19 Jan 2010 18:10:41 +1100 Stephen Rothwell wrote: > > > Hi all, > > > > Changes since 20100118: > > > When CONFIG_TUN is not enabled: > > drivers/built-in.o: In function `get_socket': > net.c:(.text+0x2899a3): undefined reference to `tun_get_socket' > > > so VHOST_NET can either depend on TUN or select TUN, but if it > selects TUN, it will also need to select CRC32. > > --- > ~Randy Oh, I fixed this already but then I lost the patch: http://lkml.org/lkml/2009/11/10/137 Sorry about that, I'll repost the fix immediately. -- MST ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for January 19 (vhost_net) 2010-01-20 10:16 ` Michael S. Tsirkin @ 2010-01-20 11:37 ` Stephen Rothwell 0 siblings, 0 replies; 5+ messages in thread From: Stephen Rothwell @ 2010-01-20 11:37 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: Randy Dunlap, netdev, linux-next, LKML [-- Attachment #1: Type: text/plain, Size: 371 bytes --] Hi Michael, On Wed, 20 Jan 2010 12:16:44 +0200 "Michael S. Tsirkin" <mst@redhat.com> wrote: > > Oh, I fixed this already but then I lost the patch: > http://lkml.org/lkml/2009/11/10/137 > > Sorry about that, I'll repost the fix immediately. Thanks. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for January 19 (vhost_net) 2010-01-19 18:41 ` linux-next: Tree for January 19 (vhost_net) Randy Dunlap 2010-01-20 10:16 ` Michael S. Tsirkin @ 2010-01-20 11:33 ` Michael S. Tsirkin 2010-01-20 15:48 ` Randy Dunlap 1 sibling, 1 reply; 5+ messages in thread From: Michael S. Tsirkin @ 2010-01-20 11:33 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, netdev, linux-next, LKML On Tue, Jan 19, 2010 at 10:41:39AM -0800, Randy Dunlap wrote: > On Tue, 19 Jan 2010 18:10:41 +1100 Stephen Rothwell wrote: > > > Hi all, > > > > Changes since 20100118: > > > When CONFIG_TUN is not enabled: > > drivers/built-in.o: In function `get_socket': > net.c:(.text+0x2899a3): undefined reference to `tun_get_socket' > > > so VHOST_NET can either depend on TUN or select TUN, but if it > selects TUN, it will also need to select CRC32. > > --- > ~Randy Just to clarify sure, the broken configuration is VHOST=y TUN=m, I sent a fixup patch to forbid that configuration. But both VHOST=y TUN=n and VHOST=m TUN=n build fine for me on linux-next (commit af2b07e7e0a9c6bf82ce4d6a77f0412ae54f575b). Randy, could you please confirm that VHOST=y TUN=m is what you tested, or alternatively make your .config available to me so I can reproduce the problem? Thanks! -- MST ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for January 19 (vhost_net) 2010-01-20 11:33 ` Michael S. Tsirkin @ 2010-01-20 15:48 ` Randy Dunlap 0 siblings, 0 replies; 5+ messages in thread From: Randy Dunlap @ 2010-01-20 15:48 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: Stephen Rothwell, netdev, linux-next, LKML On Wed, 20 Jan 2010 13:33:41 +0200 Michael S. Tsirkin wrote: > On Tue, Jan 19, 2010 at 10:41:39AM -0800, Randy Dunlap wrote: > > On Tue, 19 Jan 2010 18:10:41 +1100 Stephen Rothwell wrote: > > > > > Hi all, > > > > > > Changes since 20100118: > > > > > > When CONFIG_TUN is not enabled: > > > > drivers/built-in.o: In function `get_socket': > > net.c:(.text+0x2899a3): undefined reference to `tun_get_socket' > > > > > > so VHOST_NET can either depend on TUN or select TUN, but if it > > selects TUN, it will also need to select CRC32. > > > > --- > > ~Randy > > Just to clarify sure, the broken configuration is VHOST=y TUN=m, I sent > a fixup patch to forbid that configuration. But both VHOST=y TUN=n and > VHOST=m TUN=n build fine for me on linux-next (commit > af2b07e7e0a9c6bf82ce4d6a77f0412ae54f575b). Randy, could you please > confirm that VHOST=y TUN=m is what you tested, or alternatively make > your .config available to me so I can reproduce the problem? Hi Michael, You are correct, VHOST_NET=y, TUN=m. Thanks. --- ~Randy ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-01-20 15:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100119181041.ab55f645.sfr@canb.auug.org.au>
2010-01-19 18:41 ` linux-next: Tree for January 19 (vhost_net) Randy Dunlap
2010-01-20 10:16 ` Michael S. Tsirkin
2010-01-20 11:37 ` Stephen Rothwell
2010-01-20 11:33 ` Michael S. Tsirkin
2010-01-20 15:48 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).