From: Denys Fedoryshchenko <denys@visp.net.lb>
To: "Damian Lukowski" <damian@tvk.rwth-aachen.de>,
"Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>,
netdev@vger.kernel.org
Subject: Re: Crazy TCP bug (keepalive flood?) in 2.6.32?
Date: Tue, 19 Jan 2010 13:09:03 +0200 [thread overview]
Message-ID: <201001191309.03927.denys@visp.net.lb> (raw)
In-Reply-To: <4B5576F4.5020002@tvk.rwth-aachen.de>
On Tuesday 19 January 2010 11:10:12 you wrote:
> Hi,
> thank you for testing. So srtt and rttvar is zero in any of those cases.
> Ilpo, it is a bug in tcp_rtt_estimator then, I suppose?
>
> There is also a code comment in tcp_input.c, saying:
> > * NOTE: clamping at TCP_RTO_MIN is not required, current algo
> > * guarantees that rto is higher.
>
> So we either fix tcp_rtt_estimator or simply clamp at TCP_RTO_MIN?
>
> Damian
>
> > On Monday 11 January 2010 15:02:34 you wrote:
> >> On Sat, 26 Dec 2009, Denys Fedoryshchenko wrote:
> >>> Few more dumps. I notice:
> >>> 1)Ack always equal 1
> >>> 2)It is usually first segment of data sent (?)
> >>>
> >>> Maybe some value not initialised properly?
> >>
> >> Can you see if the RTO lower bound is violated (I added some printing of
> >> vars there too already now if it turns out to be something):
> >>
> >> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> >> index 65b8ebf..d84469f 100644
> >> --- a/net/ipv4/tcp_ipv4.c
> >> +++ b/net/ipv4/tcp_ipv4.c
As i see in code it is rounding RTO to minimum value.
It fixes my problem seems.
Btw just a bit about my environment - wireless networks (sometimes lossy!)
with low speed (128-512Kbps) customers working over pppoe. Maybe it will give
a tip why rtt value is too low.
next prev parent reply other threads:[~2010-01-19 11:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-26 15:03 Crazy TCP bug (keepalive flood?) in 2.6.32? Denys Fedoryshchenko
2009-12-26 19:24 ` Ilpo Järvinen
2010-01-11 13:02 ` Ilpo Järvinen
2010-01-16 14:12 ` Denys Fedoryshchenko
2010-01-19 9:10 ` Damian Lukowski
2010-01-19 11:09 ` Denys Fedoryshchenko [this message]
2010-01-19 11:17 ` Ilpo Järvinen
2010-01-23 21:37 ` Denys Fedoryshchenko
2010-01-23 22:34 ` [PATCH] tcp: fix ICMP-RTO war Ilpo Järvinen
2010-01-23 22:45 ` Denys Fedoryshchenko
2010-01-25 15:07 ` Damian Lukowski
2010-01-26 7:45 ` David Miller
2010-01-27 12:41 ` Ilpo Järvinen
2010-01-27 14:14 ` Alexey Kuznetsov
2010-01-23 23:28 ` Denys Fedoryshchenko
2010-01-25 12:12 ` Damian Lukowski
2010-01-27 12:36 ` Ilpo Järvinen
-- strict thread matches above, loose matches on Subject: below --
2009-12-09 18:51 Crazy TCP bug (keepalive flood?) in 2.6.32? Denys Fedoryshchenko
2009-12-10 8:24 ` Ilpo Järvinen
2009-12-10 8:28 ` Ilpo Järvinen
2009-12-10 8:50 ` Ilpo Järvinen
2009-12-10 10:05 ` Damian Lukowski
2009-12-10 10:24 ` Ilpo Järvinen
2009-12-26 14:54 ` Denys Fedoryshchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001191309.03927.denys@visp.net.lb \
--to=denys@visp.net.lb \
--cc=damian@tvk.rwth-aachen.de \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).