From: Andi Kleen <andi@firstfloor.org>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>
Subject: Re: [net-next-2.6 PATCH 1/5] ixgbe: Allocate driver resources per NUMA node
Date: Tue, 19 Jan 2010 20:34:00 +0100 [thread overview]
Message-ID: <20100119193400.GB24652@basil.fritz.box> (raw)
In-Reply-To: <F86E8680A7D9D74A99DC6345E35A6929502312B0@orsmsx503.amr.corp.intel.com>
> >The problem of doing this is that the node might be full or have
> >no memory and k*alloc_node will fail then.
> >
> >So you would need a fallback to be reliable (we probably should have a
> >generic utility function for this somewhere, but we don't currently)
>
> So you'd rather see us call kzalloc() if kzalloc_node() fails, instead of immediately failing out to err_out?
Yes.
After all it's only an optimization to place memory, it's not
a functional requirement.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-01-19 19:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 4:48 [net-next-2.6 PATCH 1/5] ixgbe: Allocate driver resources per NUMA node Jeff Kirsher
2010-01-07 4:48 ` [net-next-2.6 PATCH 2/5] ixgbe: Make descriptor ring allocations NUMA-aware Jeff Kirsher
2010-01-08 8:21 ` David Miller
2010-01-08 8:25 ` Waskiewicz Jr, Peter P
2010-01-08 8:31 ` David Miller
2010-01-08 8:36 ` Waskiewicz Jr, Peter P
2010-01-07 4:49 ` [net-next-2.6 PATCH 3/5] ethtool: Introduce n-tuple filter programming support Jeff Kirsher
2010-01-08 8:23 ` David Miller
2010-01-08 8:34 ` Waskiewicz Jr, Peter P
2010-01-08 8:38 ` David Miller
2010-01-08 8:42 ` Waskiewicz Jr, Peter P
2010-01-11 19:32 ` Ben Hutchings
2010-01-12 19:13 ` Waskiewicz Jr, Peter P
2010-01-21 2:54 ` David Miller
2010-01-07 4:49 ` [net-next-2.6 PATCH 4/5] ixgbe: Add Flow Director configuration support as a mod parameter Jeff Kirsher
2010-01-08 8:24 ` David Miller
2010-01-08 8:28 ` Waskiewicz Jr, Peter P
2010-01-08 8:32 ` David Miller
2010-01-08 8:36 ` Waskiewicz Jr, Peter P
2010-01-07 4:49 ` [net-next-2.6 PATCH 5/5] ixgbe: Add support for the new ethtool n-tuple programming interface Jeff Kirsher
2010-01-08 8:26 ` David Miller
2010-01-14 11:02 ` [net-next-2.6 PATCH 1/5] ixgbe: Allocate driver resources per NUMA node Andi Kleen
2010-01-19 16:10 ` Waskiewicz Jr, Peter P
2010-01-19 19:34 ` Andi Kleen [this message]
2010-01-19 19:34 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119193400.GB24652@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).