netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: julia@diku.dk, sri@us.ibm.com, linux-sctp@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 4/9] net/sctp: Eliminate useless code
Date: Wed, 20 Jan 2010 15:03:43 -0800 (PST)	[thread overview]
Message-ID: <20100120.150343.236848237.davem@davemloft.net> (raw)
In-Reply-To: <4B574702.4040602@hp.com>

From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Wed, 20 Jan 2010 13:10:10 -0500

> 
> 
> Julia Lawall wrote:
>> From: Julia Lawall <julia@diku.dk>
>> 
>> The variable newinet is initialized twice to the same (side effect-free)
>> expression.  Drop one initialization.
>> 
>> A simplified version of the semantic match that finds this problem is:
>> (http://coccinelle.lip6.fr/)
>> 
>> // <smpl>
>> @forall@
>> idexpression *x;
>> identifier f!=ERR_PTR;
>> @@
>> 
>> x = f(...)
>> ... when != x
>> (
>> x = f(...,<+...x...+>,...)
>> |
>> * x = f(...)
>> )
>> // </smpl>
>> 
>> Signed-off-by: Julia Lawall <julia@diku.dk>
> 
> Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>

Julia,  just like patch #3 this one had the missing final
line of the patch corrupting it, so you'll need to resubmit.

  reply	other threads:[~2010-01-20 23:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-16 15:58 [PATCH 4/9] net/sctp: Eliminate useless code Julia Lawall
2010-01-20 18:10 ` Vlad Yasevich
2010-01-20 23:03   ` David Miller [this message]
2010-01-21 10:21     ` Julia Lawall
2010-01-21 10:22     ` Julia Lawall
2010-01-21 10:43       ` David Miller
2010-01-21 10:49         ` Julia Lawall
2010-01-21 13:08           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100120.150343.236848237.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sri@us.ibm.com \
    --cc=vladislav.yasevich@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).