From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: linux-next: Tree for January 19 (vhost_net) Date: Wed, 20 Jan 2010 13:33:41 +0200 Message-ID: <20100120113341.GA9610@redhat.com> References: <20100119181041.ab55f645.sfr@canb.auug.org.au> <20100119104139.2ec9164b.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stephen Rothwell , netdev , linux-next@vger.kernel.org, LKML To: Randy Dunlap Return-path: Content-Disposition: inline In-Reply-To: <20100119104139.2ec9164b.randy.dunlap@oracle.com> Sender: linux-next-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Jan 19, 2010 at 10:41:39AM -0800, Randy Dunlap wrote: > On Tue, 19 Jan 2010 18:10:41 +1100 Stephen Rothwell wrote: > > > Hi all, > > > > Changes since 20100118: > > > When CONFIG_TUN is not enabled: > > drivers/built-in.o: In function `get_socket': > net.c:(.text+0x2899a3): undefined reference to `tun_get_socket' > > > so VHOST_NET can either depend on TUN or select TUN, but if it > selects TUN, it will also need to select CRC32. > > --- > ~Randy Just to clarify sure, the broken configuration is VHOST=y TUN=m, I sent a fixup patch to forbid that configuration. But both VHOST=y TUN=n and VHOST=m TUN=n build fine for me on linux-next (commit af2b07e7e0a9c6bf82ce4d6a77f0412ae54f575b). Randy, could you please confirm that VHOST=y TUN=m is what you tested, or alternatively make your .config available to me so I can reproduce the problem? Thanks! -- MST