From: David Miller <davem@davemloft.net>
To: krkumar2@in.ibm.com
Cc: eric.dumazet@gmail.com, ilpo.jarvinen@helsinki.fi,
netdev@vger.kernel.org
Subject: Re: [RFC] [PATCH] Optimize TCP sendmsg in favour of fast devices?
Date: Thu, 21 Jan 2010 01:25:20 -0800 (PST) [thread overview]
Message-ID: <20100121.012520.254679483.davem@davemloft.net> (raw)
In-Reply-To: <OF0A3AFFAB.FFA8088C-ON652576B1.001D7B08-652576B1.0042980B@in.ibm.com>
From: Krishna Kumar2 <krkumar2@in.ibm.com>
Date: Wed, 20 Jan 2010 17:49:18 +0530
> I had to remove the F_SG flag from cxgb3 driver (using ethtool
> didn't show any difference in performance since GSO was enabled
> on the device due to register_netdev setting it). Testing show a
> drop of 25% in performance with this patch for non-SG device,
> the extra alloc/memcpy is showing up.
>
> For the SG driver, I get a good performace gain (not anywhere
> close to 25% though). What do you suggest?
I don't think we can add your change if it hurts non-SG
devices that much.
next prev parent reply other threads:[~2010-01-21 9:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 5:33 [RFC] [PATCH] Optimize TCP sendmsg in favour of fast devices? Krishna Kumar
2010-01-15 8:36 ` David Miller
2010-01-15 8:50 ` Simon Kagstrom
2010-01-15 8:52 ` David Miller
2010-01-15 9:00 ` Simon Kagstrom
2010-01-15 9:04 ` David Miller
2010-01-15 9:03 ` Krishna Kumar2
[not found] ` <OF1B0853DD.2824263E-ON652576AC.002FA9D4-652576AC.0030AC47@LocalDomain>
2010-01-15 9:20 ` Krishna Kumar2
2010-01-15 9:18 ` David Miller
2010-01-20 12:19 ` Krishna Kumar2
2010-01-21 9:25 ` David Miller [this message]
2010-01-21 9:41 ` Herbert Xu
2010-01-27 7:12 ` Krishna Kumar2
2010-01-29 9:06 ` Herbert Xu
2010-01-29 11:15 ` Krishna Kumar2
2010-01-29 11:33 ` Herbert Xu
2010-01-29 11:50 ` Krishna Kumar2
2010-01-29 20:02 ` Rick Jones
2010-01-29 19:56 ` Rick Jones
[not found] ` <OF7EA723DA.DC2FF4FC-ON652576B8.002064CB-652576B8.00267739@LocalDomain>
2010-01-27 9:42 ` Krishna Kumar2
2010-01-29 9:07 ` Herbert Xu
2010-01-15 18:13 ` Rick Jones
2010-01-16 6:38 ` Krishna Kumar2
2010-01-19 17:41 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121.012520.254679483.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).