From: David Miller <davem@davemloft.net>
To: kristoffer@gaisler.com
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com
Subject: Re: [PATCH 1/1 V2] net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver
Date: Thu, 21 Jan 2010 22:47:48 -0800 (PST) [thread overview]
Message-ID: <20100121.224748.251929245.davem@davemloft.net> (raw)
In-Reply-To: <1263827277-7165-2-git-send-email-kristoffer@gaisler.com>
From: Kristoffer Glembo <kristoffer@gaisler.com>
Date: Mon, 18 Jan 2010 16:07:57 +0100
> +#undef DEBUG_TX_PACKETS
> +#undef DEBUG_RX_PACKETS
There is an existing facility for doing run-time debug
enabling for things like this.
So instead of this ifdef mess, make use of netdev->msg_enable
to control various types of debugging messages.
Thanks.
prev parent reply other threads:[~2010-01-22 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 15:07 [PATCH 0/1 V2] net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver Kristoffer Glembo
2010-01-18 15:07 ` [PATCH 1/1 " Kristoffer Glembo
2010-01-22 6:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121.224748.251929245.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=kristoffer@gaisler.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).