* [PATCH] be2net: swap only first 2 fields of mcc_wrb
@ 2010-01-22 8:51 Sathya Perla
2010-01-23 9:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sathya Perla @ 2010-01-22 8:51 UTC (permalink / raw)
To: netdev
Only the first two fields of mcc wrb - embedded, payload_len
need to be cpu_to_le32() swapped while issuing a cmd to the hw.
The fields tag0, tag1 are opaque and returned back to cpu as is...
Signed-off-by: Sathya Perla <sathyap@serverengines.com>
---
drivers/net/benet/be_cmds.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
index 102ade1..fee6eee 100644
--- a/drivers/net/benet/be_cmds.c
+++ b/drivers/net/benet/be_cmds.c
@@ -286,7 +286,7 @@ static void be_wrb_hdr_prepare(struct be_mcc_wrb *wrb, int payload_len,
MCC_WRB_SGE_CNT_SHIFT;
wrb->payload_length = payload_len;
wrb->tag0 = opcode;
- be_dws_cpu_to_le(wrb, 20);
+ be_dws_cpu_to_le(wrb, 8);
}
/* Don't touch the hdr after it's prepared */
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] be2net: swap only first 2 fields of mcc_wrb
2010-01-22 8:51 [PATCH] be2net: swap only first 2 fields of mcc_wrb Sathya Perla
@ 2010-01-23 9:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-01-23 9:09 UTC (permalink / raw)
To: sathyap; +Cc: netdev
From: Sathya Perla <sathyap@serverengines.com>
Date: Fri, 22 Jan 2010 14:21:36 +0530
> Only the first two fields of mcc wrb - embedded, payload_len
> need to be cpu_to_le32() swapped while issuing a cmd to the hw.
> The fields tag0, tag1 are opaque and returned back to cpu as is...
>
> Signed-off-by: Sathya Perla <sathyap@serverengines.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-23 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-22 8:51 [PATCH] be2net: swap only first 2 fields of mcc_wrb Sathya Perla
2010-01-23 9:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).