From: David Miller <davem@davemloft.net>
To: zenczykowski@gmail.com
Cc: lorenzo@google.com, therbert@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] IPv6: fix rt_lookup in pmtu_discovery
Date: Sat, 23 Jan 2010 02:20:55 -0800 (PST) [thread overview]
Message-ID: <20100123.022055.258206634.davem@davemloft.net> (raw)
In-Reply-To: <55a4f86e1001131651j102b600fm1552a42866c3c671@mail.gmail.com>
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Wed, 13 Jan 2010 16:51:30 -0800
> I believe you are looking for the following patch.
>
> I don't think it solves the problem of source based routing to any
> (significantly) greater extent than the previous patch.
> That would actually require iterating over all IPs assigned to any
> interface on our machine.
>
> However, I really don't understand the code (nor the precise issues
> involved) sufficiently well to be certain of that.
>
> I actually think the ipv4 code path suffers from a very similar problem.
>
> Mind you - I don't think these issues are really significant problems,
> because they just mean we do PMTU once per (dest ip, src ip) instead
> of once per (dest ip).
Yes, this is about right.
Please resubmit with a proper Signed-off-by: tag so I can apply
this, thanks.
next prev parent reply other threads:[~2010-01-23 10:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 4:43 [PATCH] IPv6: fix rt_lookup in pmtu_discovery Tom Herbert
2010-01-07 9:27 ` David Miller
2010-01-08 1:05 ` Maciej Żenczykowski
2010-01-08 1:10 ` David Miller
2010-01-09 0:12 ` Lorenzo Colitti
2010-01-10 21:15 ` David Miller
2010-01-14 0:51 ` Maciej Żenczykowski
2010-01-20 22:55 ` Maciej Żenczykowski
2010-01-20 22:57 ` David Miller
2010-01-20 23:33 ` Maciej Żenczykowski
2010-01-23 10:20 ` David Miller [this message]
2010-09-27 10:05 ` [PATCH] net: Fix IPv6 PMTU disc. w/ asymmetric routes Maciej Żenczykowski
[not found] ` <AANLkTikPOHy79E1ZG=iJ-rHj0vzS+AY-mGqCEtWoXp2o@mail.gmail.com>
2010-09-27 18:11 ` David Miller
2010-09-28 20:58 ` David Miller
2010-09-28 22:37 ` Maciej Żenczykowski
2010-09-30 7:41 ` David Miller
2010-10-03 21:49 ` David Miller
2010-10-04 0:21 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100123.022055.258206634.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).