From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net: use helpers to access uc list
Date: Mon, 25 Jan 2010 02:06:28 -0800 (PST) [thread overview]
Message-ID: <20100125.020628.124583614.davem@davemloft.net> (raw)
In-Reply-To: <20100125083450.GA2902@psychotron.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Mon, 25 Jan 2010 09:34:52 +0100
> Well I use "unsigned char *" as iterator because it would allow
> smooth thansition to list_head in case of mc_list. Currently "struct
> dev_addr_list" is used to store address in the list but in the end
> "struct netdev_hw_addr *" will be used. To use "struct list_head *"
> or "struct netdev_hw_addr *" as an iterator it would be needed to
> convert all drivers at once and that's not doable. Therefore I see
> "unsigned char *" cursor as the best option.
But it's not what you want to use in the end, at all.
If you're going to use a very ugly and opaque iterator type merely to
ease transition, that's not a good reason.
next prev parent reply other threads:[~2010-01-25 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-24 10:42 [PATCH net-next-2.6] net: use helpers to access uc list Jiri Pirko
2010-01-25 7:02 ` David Miller
2010-01-25 8:34 ` Jiri Pirko
2010-01-25 10:06 ` David Miller [this message]
2010-01-25 12:14 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125.020628.124583614.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).