netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH 2/2] sfc: Use fixed-size buffers for MCDI NVRAM requests
Date: Mon, 25 Jan 2010 15:50:13 -0800 (PST)	[thread overview]
Message-ID: <20100125.155013.244358929.davem@davemloft.net> (raw)
In-Reply-To: <1264447852.2793.4.camel@achroite.uk.solarflarecom.com>

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 25 Jan 2010 19:30:52 +0000

> The low-level MCDI code always uses 32-bit MMIO operations, and
> callers must pad input and output buffers to multiples of 4 bytes.
> The MCDI NVRAM functions are not doing this.  Also, their buffers are
> declared as variable-length arrays with no explicit maximum length.
> 
> Switch to a fixed buffer size based on the chunk size used by the
> MTD driver (which is a multiple of 4).
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>

Applied.

      parent reply	other threads:[~2010-01-25 23:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-25 19:30 [PATCH 2/2] sfc: Use fixed-size buffers for MCDI NVRAM requests Ben Hutchings
2010-01-25 19:41 ` Ben Hutchings
2010-01-25 23:50 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100125.155013.244358929.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).