From: Stephen Hemminger <shemminger@vyatta.com>
To: Kristoffer Glembo <kristoffer@gaisler.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Kristoffer Glembo <kristoffer@gaisler.com>
Subject: Re: [PATCH 1/1 V4] net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver
Date: Mon, 25 Jan 2010 08:37:59 -0800 [thread overview]
Message-ID: <20100125083759.3392e2ff@nehalam> (raw)
In-Reply-To: <1264417272-3800-2-git-send-email-kristoffer@gaisler.com>
On Mon, 25 Jan 2010 12:01:12 +0100
Kristoffer Glembo <kristoffer@gaisler.com> wrote:
> +/* Wait for a register change with a timeout, jiffies used has time reference */
> +#define wait_loop(wait_statement, timeout, label_on_timeout, arg_on_timeout) \
> + { \
> + unsigned long _timeout = jiffies + HZ/100*timeout; \
> + while (wait_statement) { \
> + if (time_after(jiffies, _timeout)) { \
> + arg_on_timeout; \
> +goto label_on_timeout; \
> + } \
> + } \
> + }
Ugly macro used with same arguments, just write a single function
--
next prev parent reply other threads:[~2010-01-25 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 11:01 [PATCH 0/1 V4] net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver Kristoffer Glembo
2010-01-25 11:01 ` [PATCH 1/1 " Kristoffer Glembo
2010-01-25 16:31 ` Stephen Hemminger
2010-01-27 11:01 ` Kristoffer Glembo
2010-01-25 16:33 ` Stephen Hemminger
2010-01-25 16:36 ` Stephen Hemminger
2010-01-25 16:37 ` Stephen Hemminger [this message]
2010-01-25 16:39 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125083759.3392e2ff@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=kristoffer@gaisler.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).