From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com,
michael@moffatt.org.nz, stable@kernel.org
Subject: Re: [patch 1/1] starfire: clean up properly if firmware loading fails
Date: Tue, 26 Jan 2010 20:49:16 -0800 (PST) [thread overview]
Message-ID: <20100126.204916.34896841.davem@davemloft.net> (raw)
In-Reply-To: <201001270427.o0R4R9EQ010839@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Tue, 26 Jan 2010 20:27:09 -0800
> From: Ben Hutchings <bhutchings@solarflare.com>
>
> netdev_open() will return without cleaning up net device or hardware state
> if firmware loading fails. This results in a BUG() on a second attempt to
> bring the interface up, reported in
> <http://bugzilla.kernel.org/show_bug.cgi?id=15117>, and probably has even
> worse effects if the driver is removed afterwards.
>
> Call netdev_close() to clean up on failure.
>
> Addresses http://bugzilla.kernel.org/show_bug.cgi?id=15091
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> Reported-by: Michael Moffatt <michael@moffatt.org.nz>
> Tested-by: Michael Moffatt <michael@moffatt.org.nz>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: <stable@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied, thanks everyone!
next prev parent reply other threads:[~2010-01-27 4:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 4:27 [patch 1/1] starfire: clean up properly if firmware loading fails akpm
2010-01-27 4:49 ` David Miller [this message]
2010-01-27 4:58 ` Ben Hutchings
2010-01-27 5:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126.204916.34896841.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=bhutchings@solarflare.com \
--cc=michael@moffatt.org.nz \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).