From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: shemminger@vyatta.com, djohnson@starentnetworks.com,
sakkiped@starentnetworks.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: Fix possible NULL dereference in icmp6_dst_alloc
Date: Wed, 27 Jan 2010 05:14:10 -0800 (PST) [thread overview]
Message-ID: <20100127.051410.74328462.davem@davemloft.net> (raw)
In-Reply-To: <20100127124331.GB15611@ff.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Wed, 27 Jan 2010 12:43:31 +0000
> I'm only not sure there is a better way (comments?) to make this
> code readable.
You can make it more readable and even validate the invariant at the
same time by adding some kind of inline function if you wish.
static inline struct dst_entry *rtable_to_dst_entry(struct rtable *rt)
{
BUILD_BUG_ON(rt != &rt->u.dst);
/* Because "->u.dst" is the first member of struct rtable,
* this dereference is safe even when rt is NULL.
*/
return &rt->u.dst;
}
Something like that.
next prev parent reply other threads:[~2010-01-27 13:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 21:57 Deadlock in IPv6 code while garbage collection on the rwlock protecting the routing tree Akkipeddi, Srinivas
2009-12-22 22:36 ` Stephen Hemminger
2009-12-23 17:44 ` Dave Johnson
2009-12-23 18:13 ` Stephen Hemminger
2010-01-23 10:22 ` David Miller
2010-01-26 9:48 ` Jarek Poplawski
2010-01-26 10:35 ` Jarek Poplawski
2010-01-27 9:59 ` [PATCH] ipv6: Fix possible NULL dereference in icmp6_dst_alloc Jarek Poplawski
2010-01-27 10:14 ` David Miller
2010-01-27 10:34 ` Jarek Poplawski
2010-01-27 11:04 ` David Miller
2010-01-27 12:17 ` Jarek Poplawski
2010-01-27 12:23 ` David Miller
2010-01-27 12:43 ` Jarek Poplawski
2010-01-27 13:14 ` David Miller [this message]
2010-01-27 13:28 ` Jarek Poplawski
2010-01-27 12:35 ` Atis Elsts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127.051410.74328462.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=djohnson@starentnetworks.com \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sakkiped@starentnetworks.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).