From: Stephen Hemminger <shemminger@vyatta.com>
To: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Cc: netdev@vger.kernel.org, Samuel Ortiz <samuel@sortiz.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net/irda: sh_sir: Add SuperH IrDA driver
Date: Wed, 27 Jan 2010 22:08:35 -0800 [thread overview]
Message-ID: <20100127220835.287e972d@nehalam> (raw)
In-Reply-To: <uiqam6emt.wl%morimoto.kuninori@renesas.com>
I am happy to see an IRDA driver again, especially one
that doesn't have the UGLY_MACROS that seem to be so
common in that code.
On Thu, 28 Jan 2010 13:24:10 +0900
Kuninori Morimoto <morimoto.kuninori@renesas.com> wrote:
> +struct sh_sir_self {
> + void __iomem *membase;
> + unsigned int irq;
> + struct clk *clk;
> +
> + struct net_device *ndev;
> +
> + struct net_device_stats stats;
The network device has stats in netdev->stats now
so devices don't have to keep their own data structure.
Does the device support Fast IR mode?
--
next prev parent reply other threads:[~2010-01-28 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 4:24 [PATCH] net/irda: sh_sir: Add SuperH IrDA driver Kuninori Morimoto
2010-01-28 6:08 ` Stephen Hemminger [this message]
2010-01-28 7:33 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127220835.287e972d@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=morimoto.kuninori@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox