From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com,
john.r.fastabend@intel.com, peter.p.waskiewicz.jr@intel.com
Subject: Re: [net-2.6 PATCH 2/2] ixgbe: if ixgbe_copy_dcb_cfg is going to fail learn about it early
Date: Thu, 28 Jan 2010 05:57:03 -0800 (PST) [thread overview]
Message-ID: <20100128.055703.127968273.davem@davemloft.net> (raw)
In-Reply-To: <20100128023805.19441.23796.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 27 Jan 2010 18:38:06 -0800
> From: John Fastabend <john.r.fastabend@intel.com>
>
> Call ixgbe_copy_dcb_cfg() earlier in the ixgbe_dcbnl_set_all() so that
> we can learn if this is going to fail as early as possible. Previously,
> ixgbe_down or ixgbe_close were being called before this check and the
> IXGBE_RESETTING bit was being set and cleared. Worse if this failed
> the corresponding ixgbe_up/ndo_open would not called.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> Acked-by: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2010-01-28 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 2:37 [net-2.6 PATCH 1/2] ixgbe: set the correct DCB bit for pg tx settings Jeff Kirsher
2010-01-28 2:38 ` [net-2.6 PATCH 2/2] ixgbe: if ixgbe_copy_dcb_cfg is going to fail learn about it early Jeff Kirsher
2010-01-28 13:57 ` David Miller [this message]
2010-01-28 13:56 ` [net-2.6 PATCH 1/2] ixgbe: set the correct DCB bit for pg tx settings David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128.055703.127968273.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).