* [PATCH 2.6.33-rc5] drivers/net: ks8851_mll ethernet network driver
@ 2010-01-27 16:03 Choi, David
2010-01-27 16:28 ` Ben Hutchings
0 siblings, 1 reply; 3+ messages in thread
From: Choi, David @ 2010-01-27 16:03 UTC (permalink / raw)
To: davem; +Cc: netdev
Hello David Miller,
I fix a bug in ks8851_mll driver, which has existed since 2.6.32-rc6.
>From : David J. Choi <david.choi@micrel.com>
Fix a bug that the data pointers in the interrupt handler are set wrong, which is related with the 5th parameter of request_irq().
Signed-off-by : David J. Choi <david.choi@micrel.com>
---
--- linux-2.6.33-rc5/drivers/net/ks8851_mll.c.orig 2010-01-26 17:36:51.000000000 -0800
+++ linux-2.6.33-rc5/drivers/net/ks8851_mll.c 2010-01-26 17:34:34.000000000 -0800
@@ -854,8 +854,8 @@ static void ks_update_link_status(struct
static irqreturn_t ks_irq(int irq, void *pw)
{
- struct ks_net *ks = pw;
- struct net_device *netdev = ks->netdev;
+ struct net_device *netdev = pw;
+ struct ks_net *ks = netdev_priv(netdev);
u16 status;
/*this should be the first in IRQ handler */
---
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2.6.33-rc5] drivers/net: ks8851_mll ethernet network driver
2010-01-27 16:03 [PATCH 2.6.33-rc5] drivers/net: ks8851_mll ethernet network driver Choi, David
@ 2010-01-27 16:28 ` Ben Hutchings
2010-01-28 13:59 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2010-01-27 16:28 UTC (permalink / raw)
To: davem; +Cc: Choi, David, netdev
On Wed, 2010-01-27 at 08:03 -0800, Choi, David wrote:
> Hello David Miller,
>
> I fix a bug in ks8851_mll driver, which has existed since 2.6.32-rc6.
>
> From : David J. Choi <david.choi@micrel.com>
>
> Fix a bug that the data pointers in the interrupt handler are set wrong, which is related with the 5th parameter of request_irq().
>
> Signed-off-by : David J. Choi <david.choi@micrel.com>
This should go to stable as well since the driver will be useless
without this.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2.6.33-rc5] drivers/net: ks8851_mll ethernet network driver
2010-01-27 16:28 ` Ben Hutchings
@ 2010-01-28 13:59 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-01-28 13:59 UTC (permalink / raw)
To: bhutchings; +Cc: David.Choi, netdev
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 27 Jan 2010 16:28:33 +0000
> On Wed, 2010-01-27 at 08:03 -0800, Choi, David wrote:
>> Hello David Miller,
>>
>> I fix a bug in ks8851_mll driver, which has existed since 2.6.32-rc6.
>>
>> From : David J. Choi <david.choi@micrel.com>
>>
>> Fix a bug that the data pointers in the interrupt handler are set wrong, which is related with the 5th parameter of request_irq().
>>
>> Signed-off-by : David J. Choi <david.choi@micrel.com>
>
> This should go to stable as well since the driver will be useless
> without this.
Applied and queued to -stable.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-28 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-27 16:03 [PATCH 2.6.33-rc5] drivers/net: ks8851_mll ethernet network driver Choi, David
2010-01-27 16:28 ` Ben Hutchings
2010-01-28 13:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).