From: Andreas Mohr <andi@lisas.de>
To: David Miller <davem@davemloft.net>, Arnd Bergmann <arnd@arndb.de>,
David Hollis <dhollis@davehollis.com>,
Phil Chang <pchang23@sbcglobal.net>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH 3/4] MCS7830 USB-Ether: change register define
Date: Sun, 31 Jan 2010 13:58:33 +0100 [thread overview]
Message-ID: <20100131125833.GC13435@rhlx01.hs-esslingen.de> (raw)
ChangeLog:
- rename register, add comment
Signed-off-by: Andreas Mohr <andi@lisas.de>
Index: linux-2.6.33-rc4/drivers/net/usb/mcs7830.c
===================================================================
--- linux-2.6.33-rc4.orig/drivers/net/usb/mcs7830.c 2010-01-31 12:34:45.000000000 +0100
+++ linux-2.6.33-rc4/drivers/net/usb/mcs7830.c 2010-01-31 12:34:51.000000000 +0100
@@ -85,6 +85,7 @@
HIF_REG_PHY_CMD2_PEND_FLAG_BIT = 0x80,
HIF_REG_PHY_CMD2_READY_FLAG_BIT = 0x40,
HIF_REG_CONFIG = 0x0e,
+ /* hmm, spec sez: "R/W", "Except bit 3" (likely TXENABLE). */
HIF_REG_CONFIG_CFG = 0x80,
HIF_REG_CONFIG_SPEED100 = 0x40,
HIF_REG_CONFIG_FULLDUPLEX_ENABLE = 0x20,
@@ -94,7 +95,7 @@
HIF_REG_CONFIG_ALLMULTICAST = 0x02,
HIF_REG_CONFIG_PROMISCUOUS = 0x01,
HIF_REG_ETHERNET_ADDR = 0x0f,
- HIF_REG_22 = 0x15,
+ HIF_REG_FRAME_DROP_COUNTER = 0x15, /* 0..ff; reset: 0 */
HIF_REG_PAUSE_THRESHOLD = 0x16,
HIF_REG_PAUSE_THRESHOLD_DEFAULT = 0,
};
@@ -334,7 +335,7 @@
{
u8 dummy[2];
int ret;
- ret = mcs7830_get_reg(dev, HIF_REG_22, 2, dummy);
+ ret = mcs7830_get_reg(dev, HIF_REG_FRAME_DROP_COUNTER, 2, dummy);
if (ret > 0)
return 2; /* Rev C or later */
return 1; /* earlier revision */
--
GNU/Linux. It's not the software that's free, it's you.
next reply other threads:[~2010-01-31 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 12:58 Andreas Mohr [this message]
2010-02-04 2:29 ` [PATCH 3/4] MCS7830 USB-Ether: change register define David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100131125833.GC13435@rhlx01.hs-esslingen.de \
--to=andi@lisas.de \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dhollis@davehollis.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pchang23@sbcglobal.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox