From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net: use helpers to access mc list
Date: Tue, 02 Feb 2010 07:25:33 -0800 (PST) [thread overview]
Message-ID: <20100202.072533.52179643.davem@davemloft.net> (raw)
In-Reply-To: <20100126145738.GA2537@psychotron.lab.eng.brq.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Tue, 26 Jan 2010 15:57:39 +0100
> Temporary macro "netdev_for_each_mc_addr" works in the ugly way, I'm aware, but
> it will be replaced. It uses iterator stored in "struct net_device". In every
> iteration, it copies addr from the list to "struct netdev_hw_addr" instance
> (also stored in "struct net_device"). Driver reads address stored in this
> structure. All is protected by addr_list_lock held by a caller.
This kind of ugly hack is rarely necessary, so I'm not applying
this, sorry.
In the macros, use the iterator type the driver instances already use,
which is the mcaddr entry pointer.
Then by using list_for_each_entry() things should "just work".
next prev parent reply other threads:[~2010-02-02 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 14:57 [PATCH net-next-2.6] net: use helpers to access mc list Jiri Pirko
2010-02-02 15:25 ` David Miller [this message]
2010-02-02 16:03 ` Jiri Pirko
2010-02-02 16:06 ` David Miller
2010-02-02 16:31 ` Jiri Pirko
2010-02-02 17:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202.072533.52179643.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).